'Re: Review Request 118869: Use QElapsedTimer for data engines'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118869: Use QElapsedTimer for data engines
From:       "Commit Hook" <null () kde ! org>
Date:       2014-06-23 11:05:16
Message-ID: 20140623110516.31954.64200 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118869/#review60781
-----------------------------------------------------------

This review has been submitted with commit fec57bdaa2622efbab88061e3d84fda03a806376 \
by Christoph Feck to branch master.

- Commit Hook

On June 23, 2014, 11:03 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118869/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 11:03 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Bugs: 336551
> http://bugs.kde.org/show_bug.cgi?id=336551
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> As described in bug 336551, plasma data engines use QTime to find out about elapsed \
> time. The problem is that QTime handles time zones, and therefore reads \
> /etc/localtime on each call. 
> Instead, it should use QElapsedTimer. This fixes both the performance issue, as \
> well as the FIXME from the comment about not handled 24-h wraps and timezone \
> changes. 
> There are probably more places where this can be changed.
> 
> 
> Diffs
> -----
> 
> plasma/datacontainer.cpp d19b1a5 
> plasma/dataengine.cpp 9612574 
> plasma/private/datacontainer_p.h a3e1f00 
> plasma/private/dataengine_p.h 74a61e2 
> 
> Diff: https://git.reviewboard.kde.org/r/118869/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118869/">https://git.reviewboard.kde.org/r/118869/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fec57bdaa2622efbab88061e3d84fda03a806376 by Christoph Feck to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 23rd, 2014, 11:03 a.m. UTC, Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated June 23, 2014, 11:03 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=336551">336551</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As described in bug 336551, plasma data engines use QTime to find out \
about elapsed time. The problem is that QTime handles time zones, and therefore reads \
/etc/localtime on each call.

Instead, it should use QElapsedTimer. This fixes both the performance issue, as well \
as the FIXME from the comment about not handled 24-h wraps and timezone changes.

There are probably more places where this can be changed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/datacontainer.cpp <span style="color: grey">(d19b1a5)</span></li>

 <li>plasma/dataengine.cpp <span style="color: grey">(9612574)</span></li>

 <li>plasma/private/datacontainer_p.h <span style="color: grey">(a3e1f00)</span></li>

 <li>plasma/private/dataengine_p.h <span style="color: grey">(74a61e2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118869/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 