'Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118876: Remove start in systemtray option from the kmenuedit.
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-06-23 11:00:02
Message-ID: 20140623110002.31954.37781 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On June 22, 2014, 6:58 p.m., Martin Gräßlin wrote:
> > I think the suggestion to port ksystemtraycmd to SNI is wrong: we don't want \
> > applications in the system tray. Removing X11 support from system tray is one \
> > part of the story for that.

We do want to allow apps in the systemtray in principle, but be able to move them \
elsewhere. So a ksystemtraycmd using SNI would accomplish that (since it attaches \
enough metadata, category for example). Not supporting X11/FDO systray spec is a \
technical thing (it's almost impossible to do well in a scenegraph world). Therefore, \
porting ksystemtraycmd to SNI makes sense.

- Sebastian

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118876/#review60725
-----------------------------------------------------------

On June 22, 2014, 12:36 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118876/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:36 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kmenuedit
> 
> 
> Description
> -------
> 
> This option uses ksystraycmd tool which is removed long ago
> 
> http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7
> 
> 
> Diffs
> -----
> 
> basictab.h 9aa4c18 
> basictab.cpp 6e3e086 
> 
> Diff: https://git.reviewboard.kde.org/r/118876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118876/">https://git.reviewboard.kde.org/r/118876/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 22nd, 2014, 6:58 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think the suggestion to port ksystemtraycmd to SNI is wrong: we \
don&#39;t want applications in the system tray. Removing X11 support from system tray \
is one part of the story for that.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We do want to allow apps \
in the systemtray in principle, but be able to move them elsewhere. So a \
ksystemtraycmd using SNI would accomplish that (since it attaches enough metadata, \
category for example). Not supporting X11/FDO systray spec is a technical thing \
(it&#39;s almost impossible to do well in a scenegraph world). Therefore, porting \
ksystemtraycmd to SNI makes sense.</pre> <br />

<p>- Sebastian</p>

<br />
<p>On June 22nd, 2014, 12:36 p.m. UTC, Bhushan Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated June 22, 2014, 12:36 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmenuedit
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This option uses ksystraycmd tool which is removed long ago

http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>basictab.h <span style="color: grey">(9aa4c18)</span></li>

 <li>basictab.cpp <span style="color: grey">(6e3e086)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118876/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 