[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.
From: "Jonathan Riddell" <jr () jriddell ! org>
Date: 2014-06-23 10:40:57
Message-ID: 20140623104057.22642.86256 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote:
> > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN.
> >
> > The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with \
> > libkonq.so.5 pointing to it.
> > With this change libkonq has a lower version (4.97.0; libkonq.so.4.97.0) with \
> > libkonq.so.5 pointing to it.
> > This would mean that libkonq is no longer co-installable with its KDE4 version \
> > due to both using libkonq.so.5. Given that there must have been a reason in the \
> > past to use libkonq.so.5.14.0, I would suggest to move libkonq version to 5.97.0 \
> > and use libkonq.so.6. This would ensure co-instability and consistency in version \
> > numbering.
>
> Christoph Feck wrote:
> Another idea is to rename the library to KF5 naming conventions. Maybe even drop \
> the "konq" name, and use something which better describes it.
pushed a change to set it to 6.0.0
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118851/#review60757
-----------------------------------------------------------
On June 20, 2014, 8:14 p.m., Scarlett Clark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118851/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 8:14 p.m.)
>
>
> Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> I was ending up with so.SOVERSION when building this, so through some research I \
> have come up with this patch to correct the issue. If there is a better way, please \
> let me know.
>
> Diffs
> -----
>
> CMakeLists.txt a5588ea
> dolphin/src/CMakeLists.txt ce629fb
> lib/konq/CMakeLists.txt 6857e19
>
> Diff: https://git.reviewboard.kde.org/r/118851/diff/
>
>
> Testing
> -------
>
> Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
> libdolphinprivate.so
> libdolphinprivate.so.4.97.0
> libdolphinprivate.so.5
> libkdeinit5_dolphin.so
> libkonq.so
> libkonq.so.4.97.0
> libkonq.so.5
>
>
> Thanks,
>
> Scarlett Clark
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118851/">https://git.reviewboard.kde.org/r/118851/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 23rd, 2014, 9:16 a.m. UTC, <b>Raymond \
Wooninck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hmm, now we seem to have a strange situation between KDE4 and KF5/PN.
The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with \
libkonq.so.5 pointing to it.
With this change libkonq has a lower version (4.97.0; libkonq.so.4.97.0) with \
libkonq.so.5 pointing to it.
This would mean that libkonq is no longer co-installable with its KDE4 version due to \
both using libkonq.so.5. Given that there must have been a reason in the past to use \
libkonq.so.5.14.0, I would suggest to move libkonq version to 5.97.0 and use \
libkonq.so.6. This would ensure co-instability and consistency in version numbering. \
</pre> </blockquote>
<p>On June 23rd, 2014, 10:09 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another idea is to \
rename the library to KF5 naming conventions. Maybe even drop the "konq" \
name, and use something which better describes it.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pushed a change to set \
it to 6.0.0</pre> <br />
<p>- Jonathan</p>
<br />
<p>On June 20th, 2014, 8:14 p.m. UTC, Scarlett Clark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.</div>
<div>By Scarlett Clark.</div>
<p style="color: grey;"><i>Updated June 20, 2014, 8:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was ending up with so.SOVERSION when building this, so through some \
research I have come up with this patch to correct the issue. If there is a better \
way, please let me know.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds fine on Kubuntu Utopic frameworks chroot. Results in the \
expected: libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a5588ea)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(ce629fb)</span></li>
<li>lib/konq/CMakeLists.txt <span style="color: grey">(6857e19)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118851/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic