[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-06-23 9:51:46
Message-ID: 20140623095146.6826.66877 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118865/#review60767
-----------------------------------------------------------
In Plasma Next we're following XDG standard, therefore KDEHOME is not required. This \
error indicates there's a problem somewhere else looking for a deprecated .kde \
directory.
Please report it on bugs.kde.org. :)
- Aleix Pol Gonzalez
On June 21, 2014, 2:26 p.m., José Manuel Santamaría Lema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118865/
> -----------------------------------------------------------
>
> (Updated June 21, 2014, 2:26 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Hi,
>
> I have been working a bit in kubuntu's plasma packaging, when I started plasma from \
> a fresh new account I noticed I couldn't see most icons in the GUI's except for a \
> few ones.
> So I checked the starkde output to try to find out what was wrong, I found a line \
> like this one: static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to \
> determine KDEHOME
> Digging a bit more into the issue I also found out where this message comes from.
> File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0) lines \
> 446-468: QPlatformTheme *QKdeTheme::createKdeTheme()
> {
> // Check for version >= 4 and determine home folder from environment,
> // defaulting to ~/.kde<version>, ~/.kde
> const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
> const int kdeVersion = kdeVersionBA.toInt();
> if (kdeVersion < 4)
> return 0;
> const QString kdeHomePathVar = QString::fromLocal8Bit(qgetenv("KDEHOME"));
> if (!kdeHomePathVar.isEmpty())
> return new QKdeTheme(kdeHomePathVar, kdeVersion);
>
> const QString kdeVersionHomePath = QDir::homePath() + QStringLiteral("/.kde") + \
> QLatin1String(kdeVersionBA); if (QFileInfo(kdeVersionHomePath).isDir())
> return new QKdeTheme(kdeVersionHomePath, kdeVersion);
>
> const QString kdeHomePath = QDir::homePath() + QStringLiteral("/.kde");
> if (QFileInfo(kdeHomePath).isDir())
> return new QKdeTheme(kdeHomePath, kdeVersion);
>
> qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
> return 0;
> }
>
> So I'm inclined to think the ~/.kde directory should be created if it doesn't \
> exist, thats what the patch does. What do you think?
>
> Diffs
> -----
>
> startkde/startkde.cmake ea0bdfe
>
> Diff: https://git.reviewboard.kde.org/r/118865/diff/
>
>
> Testing
> -------
>
> Applied a similar patch in a customized kubuntu package. With the patch the ~/.kde \
> directory is created and the icons can be seen.
>
> Thanks,
>
> José Manuel Santamaría Lema
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118865/">https://git.reviewboard.kde.org/r/118865/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Plasma Next we're \
following XDG standard, therefore KDEHOME is not required. This error indicates \
there's a problem somewhere else looking for a deprecated .kde directory.
Please report it on bugs.kde.org. :)</pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 21st, 2014, 2:26 p.m. UTC, José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated June 21, 2014, 2:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
I have been working a bit in kubuntu's plasma packaging, when I started plasma \
from a fresh new account I noticed I couldn't see most icons in the GUI's \
except for a few ones.
So I checked the starkde output to try to find out what was wrong, I found a line \
like this one: static QPlatformTheme* QKdeTheme::createKdeTheme(): Unable to \
determine KDEHOME
Digging a bit more into the issue I also found out where this message comes from.
File src/platformsupport/themes/genericunix/qgenericunixthemes.cpp (Qt 5.3.0) lines \
446-468: QPlatformTheme *QKdeTheme::createKdeTheme()
{
// Check for version >= 4 and determine home folder from environment,
// defaulting to ~/.kde<version>, ~/.kde
const QByteArray kdeVersionBA = qgetenv("KDE_SESSION_VERSION");
const int kdeVersion = kdeVersionBA.toInt();
if (kdeVersion < 4)
return 0;
const QString kdeHomePathVar = \
QString::fromLocal8Bit(qgetenv("KDEHOME")); if (!kdeHomePathVar.isEmpty())
return new QKdeTheme(kdeHomePathVar, kdeVersion);
const QString kdeVersionHomePath = QDir::homePath() + \
QStringLiteral("/.kde") + QLatin1String(kdeVersionBA); if \
(QFileInfo(kdeVersionHomePath).isDir()) return new QKdeTheme(kdeVersionHomePath, \
kdeVersion);
const QString kdeHomePath = QDir::homePath() + \
QStringLiteral("/.kde"); if (QFileInfo(kdeHomePath).isDir())
return new QKdeTheme(kdeHomePath, kdeVersion);
qWarning("%s: Unable to determine KDEHOME", Q_FUNC_INFO);
return 0;
}
So I'm inclined to think the ~/.kde directory should be created if it doesn't \
exist, thats what the patch does. What do you think? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applied a similar patch in a customized kubuntu package. With the patch \
the ~/.kde directory is created and the icons can be seen.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/startkde.cmake <span style="color: grey">(ea0bdfe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118865/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic