[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118866: Start playing after Play All is used
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2014-06-21 17:43:54
Message-ID: 20140621174354.21547.46007 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118866/
-----------------------------------------------------------
(Updated June 21, 2014, 5:43 p.m.)
Review request for Plasma.
Changes
-------
switch to and clear the default playlist only
Repository: plasma-mediacenter
Description
-------
We should ask the model to start playing once we add all the songs to the playlist as \
a result of the user using "Play All".
Diffs (updated)
-----
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp \
68eecf3 libs/mediacenter/multipleplaylistmodel.h 1c7731b
libs/mediacenter/multipleplaylistmodel.cpp 4b475c7
libs/mediacenter/playlistmodel.h 50157ff
libs/mediacenter/playlistmodel.cpp 44abbc1
Diff: https://git.reviewboard.kde.org/r/118866/diff/
Testing
-------
Thanks,
Shantanu Tushar
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118866/">https://git.reviewboard.kde.org/r/118866/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated June 21, 2014, 5:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">switch to and clear the default playlist only</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We should ask the model to start playing once we add all the songs to \
the playlist as a result of the user using "Play All".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp \
<span style="color: grey">(68eecf3)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.h <span style="color: \
grey">(1c7731b)</span></li>
<li>libs/mediacenter/multipleplaylistmodel.cpp <span style="color: \
grey">(4b475c7)</span></li>
<li>libs/mediacenter/playlistmodel.h <span style="color: grey">(50157ff)</span></li>
<li>libs/mediacenter/playlistmodel.cpp <span style="color: \
grey">(44abbc1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118866/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic