[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notif
From: "Celeste Lyn Paul" <celeste () kde ! org>
Date: 2014-06-21 13:14:51
Message-ID: 20140621131451.21547.38134 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 21, 2014, 1:13 p.m., Celeste Lyn Paul wrote:
> > Ship It!
This is great and follows one of the recommendations I made in my KDE Notifications \
research.
- Celeste Lyn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118796/#review60660
-----------------------------------------------------------
On June 20, 2014, 1:28 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118796/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 1:28 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This prevents some apps to spam lots of notifications when all it needs is actually \
> just one single notification.
> Imagine you're switching songs in your playlist quickly and each song change sends \
> new notification, but when you get to the tenth song, you still see the \
> notification from the 3rd song (because timeouts) and you don't really care about \
> all those songs changes still in the queue as you see it in the playlist anyway.
> So this patch limits certain apps to have only one single notification which is \
> always updated. So far Clementine and Spotify is there. Switching songs or changing \
> playback status creates only one single popup.
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32
> applets/notifications/plugin/notificationshelper.cpp c5a1082
> dataengines/notifications/notificationsengine.h df0d3ca
> dataengines/notifications/notificationsengine.cpp aaf6079
>
> Diff: https://git.reviewboard.kde.org/r/118796/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118796/">https://git.reviewboard.kde.org/r/118796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 21st, 2014, 1:13 p.m. UTC, <b>Celeste Lyn \
Paul</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is great and \
follows one of the recommendations I made in my KDE Notifications research.</pre> <br \
/>
<p>- Celeste Lyn</p>
<br />
<p>On June 20th, 2014, 1:28 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 20, 2014, 1:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This prevents some apps to spam lots of notifications when all it needs \
is actually just one single notification.
Imagine you're switching songs in your playlist quickly and each song change \
sends new notification, but when you get to the tenth song, you still see the \
notification from the 3rd song (because timeouts) and you don't really care about \
all those songs changes still in the queue as you see it in the playlist anyway.
So this patch limits certain apps to have only one single notification which is \
always updated. So far Clementine and Spotify is there. Switching songs or changing \
playback status creates only one single popup.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/NotificationPopup.qml <span \
style="color: grey">(d07ee32)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: \
grey">(c5a1082)</span></li>
<li>dataengines/notifications/notificationsengine.h <span style="color: \
grey">(df0d3ca)</span></li>
<li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(aaf6079)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118796/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic