'Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC
From:       "Ashish Madeti" <ashishmadeti () gmail ! com>
Date:       2014-06-19 16:30:53
Message-ID: 20140619163053.17276.59456 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/
-----------------------------------------------------------

(Updated June 19, 2014, 10 p.m.)

Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, Sinny \
Kumari, and Sujith Haridasan.

Bugs: 328532
    http://bugs.kde.org/show_bug.cgi?id=328532

Repository: plasma-mediacenter

Description
-------

PMC didn't used to remember the playlist I was on the last time, when restarting it.
Now it saves the "lastPlaylist" while closing in the settings, and when starting it \
loads the value of "lastPlaylist" in settings

Diffs (updated)
-----

  libs/mediacenter/playlistmodel.cpp dccaf52 

Diff: https://git.reviewboard.kde.org/r/118767/diff/

Testing
-------

Thanks,

Ashish Madeti

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118767/">https://git.reviewboard.kde.org/r/118767/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, \
Sinny Kumari, and Sujith Haridasan.</div> <div>By Ashish Madeti.</div>

<p style="color: grey;"><i>Updated June 19, 2014, 10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=328532">328532</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">PMC didn&#39;t used to remember the playlist I was on the last time, \
when restarting it. Now it saves the &quot;lastPlaylist&quot; while closing in the \
settings, and when starting it loads the value of &quot;lastPlaylist&quot; in \
settings</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/playlistmodel.cpp <span style="color: \
grey">(dccaf52)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118767/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 