[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118665: Avoid invalid read in ShadowHelper destructor
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2014-06-19 14:30:51
Message-ID: 20140619143051.29636.16983 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/
-----------------------------------------------------------
(Updated June 19, 2014, 2:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Hugo Pereira Da Costa.
Repository: oxygen
Description
-------
Valgrind pointed out ~ShadowHelper uses _helper, but at the time ~ShadowHelper is \
called, _helper has already been deleted. Deleting ShadowHelper manually works around \
this problem. I also have an alternative patch which turns _helper into a \
QSharedPointer, which I can submit instead, but the changes are much more invasive.
Diffs
-----
kstyle/oxygenstyle.cpp 972e4c8
Diff: https://git.reviewboard.kde.org/r/118665/diff/
Testing
-------
Running "valgrind kcmshell5 desktop" does not print any error about invalid reads in \
~ShadowHelper anymore.
Thanks,
Aurélien Gâteau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118665/">https://git.reviewboard.kde.org/r/118665/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 19, 2014, 2:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Valgrind pointed out ~ShadowHelper uses _helper, but at the time \
~ShadowHelper is called, _helper has already been deleted. Deleting ShadowHelper \
manually works around this problem. I also have an alternative patch which turns \
_helper into a QSharedPointer, which I can submit instead, but the changes are much \
more invasive.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Running "valgrind kcmshell5 desktop" does not print any error \
about invalid reads in ~ShadowHelper anymore.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyle/oxygenstyle.cpp <span style="color: grey">(972e4c8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118665/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic