[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-06-17 16:15:14
Message-ID: 20140617161514.3734.25464 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118724/#review60280
-----------------------------------------------------------
Looks fine to me, I'd like David's opinion though.
- Kevin Ottens
On June 13, 2014, 11:31 a.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118724/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 11:31 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> rename .directory files to kf5 prefix to prevent clashes with kde-runtime files
> goes with https://git.reviewboard.kde.org/r/118725/
>
>
> Diffs
> -----
>
> menu/desktop/CMakeLists.txt fa6af4d214a10ee3db661a752776c1c3c31c34a8
> menu/desktop/kde-development-translation.directory
> menu/desktop/kde-development-webdevelopment.directory
> menu/desktop/kde-development.directory
> menu/desktop/kde-editors.directory
> menu/desktop/kde-edu-languages.directory
> menu/desktop/kde-edu-mathematics.directory
> menu/desktop/kde-edu-miscellaneous.directory
> menu/desktop/kde-edu-science.directory
> menu/desktop/kde-edu-tools.directory
> menu/desktop/kde-education.directory
> menu/desktop/kde-games-arcade.directory
> menu/desktop/kde-games-board.directory
> menu/desktop/kde-games-card.directory
> menu/desktop/kde-games-kids.directory
> menu/desktop/kde-games-logic.directory
> menu/desktop/kde-games-roguelikes.directory
> menu/desktop/kde-games-strategy.directory
> menu/desktop/kde-games.directory
> menu/desktop/kde-graphics.directory
> menu/desktop/kde-internet-terminal.directory
> menu/desktop/kde-internet.directory
> menu/desktop/kde-main.directory
> menu/desktop/kde-more.directory
> menu/desktop/kde-multimedia.directory
> menu/desktop/kde-office.directory
> menu/desktop/kde-science.directory
> menu/desktop/kde-settingsmenu.directory
> menu/desktop/kde-system-terminal.directory
> menu/desktop/kde-system.directory
> menu/desktop/kde-toys.directory
> menu/desktop/kde-unknown.directory
> menu/desktop/kde-utilities-accessibility.directory
> menu/desktop/kde-utilities-desktop.directory
> menu/desktop/kde-utilities-file.directory
> menu/desktop/kde-utilities-peripherals.directory
> menu/desktop/kde-utilities-pim.directory
> menu/desktop/kde-utilities-xutils.directory
> menu/desktop/kde-utilities.directory
>
> Diff: https://git.reviewboard.kde.org/r/118724/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118724/">https://git.reviewboard.kde.org/r/118724/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, \
I'd like David's opinion though.</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On June 13th, 2014, 11:31 a.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 11:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rename .directory files to kf5 prefix to prevent clashes with \
kde-runtime files goes with https://git.reviewboard.kde.org/r/118725/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>menu/desktop/CMakeLists.txt <span style="color: \
grey">(fa6af4d214a10ee3db661a752776c1c3c31c34a8)</span></li>
<li>menu/desktop/kde-development-translation.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-development-webdevelopment.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-development.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-editors.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-edu-languages.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-edu-mathematics.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-edu-miscellaneous.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-edu-science.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-edu-tools.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-education.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-arcade.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-board.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-card.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-kids.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-logic.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-games-roguelikes.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-games-strategy.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-games.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-graphics.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-internet-terminal.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-internet.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-main.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-more.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-multimedia.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-office.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-science.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-settingsmenu.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-system-terminal.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-system.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-toys.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-unknown.directory <span style="color: grey">()</span></li>
<li>menu/desktop/kde-utilities-accessibility.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities-desktop.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities-file.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities-peripherals.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities-pim.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities-xutils.directory <span style="color: \
grey">()</span></li>
<li>menu/desktop/kde-utilities.directory <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118724/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic