[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118733: Change installation path of sddm theme
From: "Bernd Steinhauser" <linux () bernd-steinhauser ! de>
Date: 2014-06-13 16:30:41
Message-ID: 20140613163041.8193.18950 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 118
> > <https://git.reviewboard.kde.org/r/118733/diff/1/?file=280911#file280911line118>
> >
> > Actually, shouldn't we have a find_package sddm and install it wherever it's \
> > installed?
At least currently, there is no option to define the installation dir, apart from the \
prefix, it will be installed to "${CMAKE_INSTALL_FULL_DATADIR}/sddm". (Actually, \
maybe the cmake file in plasma-workspace should use CMAKE_INSTALL_FULL_DATADIR, too.)
Therefore, I fail to see the advantage of adding a FindSDDM.cmake.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118733/#review60023
-----------------------------------------------------------
On June 13, 2014, 4:09 p.m., Bernd Steinhauser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118733/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 4:09 p.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Simple thing. The default installation path changed upstream at id \
> d102be248237d3e4da0e1d0e8cdfe862851375f7 from
> /usr/share/apps/sddm
> to
> /usr/share/sddm
>
> Hence the patch updates the path, so sddm can actually find the theme.
>
>
> Diffs
> -----
>
> CMakeLists.txt 08c9084
>
> Diff: https://git.reviewboard.kde.org/r/118733/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Steinhauser
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118733/">https://git.reviewboard.kde.org/r/118733/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 13th, 2014, 4:11 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118733/diff/1/?file=280911#file280911line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">install</span><span class="p">(</span><span class="s">DIRECTORY</span> \
<span class="s">lookandfeel/contents/loginmanager/</span> <span \
class="s">DESTINATION</span> <span class="o">${</span><span \
class="nv">CMAKE_INSTALL_PREFIX</span><span class="o">}</span><span \
class="s">/share/<span class="hl">apps/</span>sddm/themes/breeze</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="nb">install</span><span \
class="p">(</span><span class="s">DIRECTORY</span> <span \
class="s">lookandfeel/contents/loginmanager/</span> <span \
class="s">DESTINATION</span> <span class="o">${</span><span \
class="nv">CMAKE_INSTALL_PREFIX</span><span class="o">}</span><span \
class="s">/share/sddm/themes/breeze</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, shouldn't \
we have a find_package sddm and install it wherever it's installed?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At least \
currently, there is no option to define the installation dir, apart from the prefix, \
it will be installed to "${CMAKE_INSTALL_FULL_DATADIR}/sddm". (Actually, \
maybe the cmake file in plasma-workspace should use CMAKE_INSTALL_FULL_DATADIR, too.)
Therefore, I fail to see the advantage of adding a FindSDDM.cmake.</pre>
<br />
<p>- Bernd</p>
<br />
<p>On June 13th, 2014, 4:09 p.m. UTC, Bernd Steinhauser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Bernd Steinhauser.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 4:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simple thing. The default installation path changed upstream at id \
d102be248237d3e4da0e1d0e8cdfe862851375f7 from
/usr/share/apps/sddm
to
/usr/share/sddm
Hence the patch updates the path, so sddm can actually find the theme.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(08c9084)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118733/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic