'Re: Review Request 118251: Small improvments to FadingNode and IconItem'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118251: Small improvments to FadingNode and IconItem
From:       "Commit Hook" <null () kde ! org>
Date:       2014-06-11 5:59:39
Message-ID: 20140611055939.10512.74250 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review59743
-----------------------------------------------------------

This review has been submitted with commit 0d61746784629cb9f6b8c67e06a7ff49b5dc8732 \
by Martin Gräßlin to branch master.

- Commit Hook

On June 10, 2014, 1:56 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118251/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 1:56 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Small improvments to FadingNode and IconItem
> 
> * trigger an update after the animation finished as the IconItem needs to
> switch to SVGTextureNode again
> * Don't connect needlessly to a lambda slot
> * FadingMaterialShader had the texture bind swapped
> * Fix virtual method hidden warning in FadingMaterialShader
> * Use dynamic_cast instead of static_cast to convert to SVGTextureNode
> or FadingNode.
> 
> 
> Diffs
> -----
> 
> src/declarativeimports/core/fadingnode.cpp 207eff3902848a3c76bf1ec62d73877d6d9d0df7 \
>  src/declarativeimports/core/iconitem.cpp 384017d4a9c9a96e1d465298260dffe0285712e3 
> 
> Diff: https://git.reviewboard.kde.org/r/118251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118251/">https://git.reviewboard.kde.org/r/118251/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0d61746784629cb9f6b8c67e06a7ff49b5dc8732 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 10th, 2014, 1:56 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated June 10, 2014, 1:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Small improvments to FadingNode and IconItem

* trigger an update after the animation finished as the IconItem needs to
  switch to SVGTextureNode again
* Don&#39;t connect needlessly to a lambda slot
* FadingMaterialShader had the texture bind swapped
* Fix virtual method hidden warning in FadingMaterialShader
* Use dynamic_cast instead of static_cast to convert to SVGTextureNode
  or FadingNode.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/fadingnode.cpp <span style="color: \
grey">(207eff3902848a3c76bf1ec62d73877d6d9d0df7)</span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(384017d4a9c9a96e1d465298260dffe0285712e3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118251/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 