[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118386: Give milou proper version
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2014-06-10 12:27:15
Message-ID: 20140610122715.24416.92591 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118386/#review59681
-----------------------------------------------------------

Ship it!


- Vishesh Handa


On May 28, 2014, 7:07 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118386/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 7:07 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> -------
> 
> sideeffect - coexists with 4.x version. as there's no development files, added \
> LIBRARY NAMELINK_SKIP directive. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 4bf25ae 
> lib/CMakeLists.txt 657e9dc 
> 
> Diff: https://git.reviewboard.kde.org/r/118386/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118386/">https://git.reviewboard.kde.org/r/118386/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>











<p>- Vishesh Handa</p>


<br />
<p>On May 28th, 2014, 7:07 p.m. UTC, Hrvoje Senjan wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>


<p style="color: grey;"><i>Updated May 28, 2014, 7:07 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
milou
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">sideeffect - coexists with 4.x version. as there&#39;s no development \
files, added LIBRARY NAMELINK_SKIP directive.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">builds</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(4bf25ae)</span></li>

 <li>lib/CMakeLists.txt <span style="color: grey">(657e9dc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118386/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic