'Re: Review Request 118388: rename systemsettings binary to systemsettings5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118388: rename systemsettings binary to systemsettings5
From:       "Eike Hein" <hein () kde ! org>
Date:       2014-06-09 13:21:51
Message-ID: 20140609132151.32626.18310 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review59612
-----------------------------------------------------------

If you rename the .desktop files, please remember to update the default favorites \
configurations in Kicker (it's in the main.xml of the package) and Kickoff (somewhere \
in C++ model code) since they both reference System Settings by KService storage id.

- Eike Hein

On May 28, 2014, 7:32 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 7:32 p.m.)
> 
> 
> Review request for Plasma and Ben Cooksley.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> while workspace might not be targeted to co-exist with 4.x variant - systemsettings \
> should IMHO be able to co-exist. not only workspace components are adjusting in \
> there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very \
> user-unfriendly... one TODO if this gets a green light, is to rename desktop files, \
> so people know which variant they are opening. 
> 
> Diffs
> -----
> 
> app/systemsettings.desktop 5f27318 
> app/kdesystemsettings.desktop 946d498 
> app/CMakeLists.txt c45f7e7 
> 
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118388/">https://git.reviewboard.kde.org/r/118388/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you rename the \
.desktop files, please remember to update the default favorites configurations in \
Kicker (it&#39;s in the main.xml of the package) and Kickoff (somewhere in C++ model \
code) since they both reference System Settings by KService storage id.</pre>  <br />

<p>- Eike Hein</p>

<br />
<p>On May 28th, 2014, 7:32 p.m. UTC, Hrvoje Senjan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Ben Cooksley.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated May 28, 2014, 7:32 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">while workspace might not be targeted to co-exist with 4.x variant - \
systemsettings should IMHO be able to co-exist. not only workspace components are \
adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm \
is very user-unfriendly... one TODO if this gets a green light, is to rename desktop \
files, so people know which variant they are opening.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/systemsettings.desktop <span style="color: grey">(5f27318)</span></li>

 <li>app/kdesystemsettings.desktop <span style="color: grey">(946d498)</span></li>

 <li>app/CMakeLists.txt <span style="color: grey">(c45f7e7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118388/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 