[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of K
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-06-05 1:01:56
Message-ID: 20140605010156.17694.31102 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118540/#review59258
-----------------------------------------------------------
Hi,
I was looking into applying it and it's already ported in master, it's just the last \
beta that doesn't compile against the new KF5 version.
The beta that will be released next week should work properly on the last KF5 beta.
- Aleix Pol Gonzalez
On June 4, 2014, 8:13 p.m., Eric Hameleers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118540/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 8:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kde-cli-tools
>
>
> Description
> -------
>
> Two patches were required to build a kde-cli-tools 20140603 snapshot successfully \
> on top of KDE Frameworks 4.100.0
>
> Diffs
> -----
>
> kdesu/kdesu.cpp d5c7f72
> kioclient/kioclient.cpp 71b11fb
> kreadconfig/kreadconfig.cpp 532d077
> kreadconfig/kwriteconfig.cpp e5597d3
>
> Diff: https://git.reviewboard.kde.org/r/118540/diff/
>
>
> Testing
> -------
>
> Slackware-current x86_64
>
>
> File Attachments
> ----------------
>
> kde-cli-tools_ecm.patch
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/3e33b7c2-9ac5-4bdc-8626-cc9ba9fda401__kde-cli-tools_ecm.patch
>
>
> Thanks,
>
> Eric Hameleers
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118540/">https://git.reviewboard.kde.org/r/118540/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, I was looking into \
applying it and it's already ported in master, it's just the last beta that \
doesn't compile against the new KF5 version.
The beta that will be released next week should work properly on the last KF5 \
beta.</pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 4th, 2014, 8:13 p.m. UTC, Eric Hameleers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eric Hameleers.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 8:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Two patches were required to build a kde-cli-tools 20140603 snapshot \
successfully on top of KDE Frameworks 4.100.0</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Slackware-current x86_64</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdesu/kdesu.cpp <span style="color: grey">(d5c7f72)</span></li>
<li>kioclient/kioclient.cpp <span style="color: grey">(71b11fb)</span></li>
<li>kreadconfig/kreadconfig.cpp <span style="color: grey">(532d077)</span></li>
<li>kreadconfig/kwriteconfig.cpp <span style="color: grey">(e5597d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118540/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/3e33b7c2 \
-9ac5-4bdc-8626-cc9ba9fda401__kde-cli-tools_ecm.patch">kde-cli-tools_ecm.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic