'Re: Review Request 118417: [klipper] Port from KDebug to QDebug'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118417: [klipper] Port from KDebug to QDebug
From:       "Alexander Richardson" <arichardson.kde () googlemail ! com>
Date:       2014-05-30 15:39:20
Message-ID: 20140530153920.2659.49255 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58827
-----------------------------------------------------------

Shouldn't this rather use qCDebug() so that the output can be disabled?

- Alexander Richardson

On May 30, 2014, 12:29 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118417/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 12:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KDebug to QDebug
> 
> 
> Diffs
> -----
> 
>   klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 
>   klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf 
>   klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf 
>   klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 
>   klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a 
>   klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 
>   klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 
>   klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 
>   klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 
>   klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b 
> 
> Diff: https://git.reviewboard.kde.org/r/118417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118417/">https://git.reviewboard.kde.org/r/118417/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn&#39;t this \
rather use qCDebug() so that the output can be disabled?</pre>  <br />

<p>- Alexander Richardson</p>

<br />
<p>On May 30th, 2014, 12:29 p.m. CEST, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 30, 2014, 12:29 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port from KDebug to QDebug</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>klipper/actionstreewidget.cpp <span style="color: \
grey">(201e32b821f526bc5869aaae6864a5723d2a2572)</span></li>

 <li>klipper/configdialog.cpp <span style="color: \
grey">(808be4e4ea0e42dbb3b9fb11abf4456e16caacdf)</span></li>

 <li>klipper/editactiondialog.cpp <span style="color: \
grey">(4719fc5eccf3c28b4d8824b54cbdf62d43805ebf)</span></li>

 <li>klipper/history.cpp <span style="color: \
grey">(486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1)</span></li>

 <li>klipper/historyimageitem.cpp <span style="color: \
grey">(6fcb409400e62dd55caf551f229f28ebc68ff52a)</span></li>

 <li>klipper/historyitem.cpp <span style="color: \
grey">(e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4)</span></li>

 <li>klipper/klipper.cpp <span style="color: \
grey">(8847af324ff0c0c8e07d7e69ca473945cf001772)</span></li>

 <li>klipper/klipperpopup.cpp <span style="color: \
grey">(89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07)</span></li>

 <li>klipper/popupproxy.cpp <span style="color: \
grey">(5d1b0a0d245c56c94a00cb9b191a727e008d4725)</span></li>

 <li>klipper/urlgrabber.cpp <span style="color: \
grey">(54085e8a28fb2836c80900759201f4e936da051b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118417/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 