[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118357: Disable the agenda part of the calendar
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-05-30 14:00:00
Message-ID: 20140530140000.2659.4685 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote:
> > Since the visible flag is now static false, let's comment the agenda item code, so we don't \
> > waste memory or CPU cycles. Once done, please ship.
>
> Martin Klapetek wrote:
> I specifically opted out of commenting it as that would mean commenting stuff all around \
> (stuff that references the commented out stuff). If really needed, I can do tho. On the other \
> hand, if this is to make things faster, it will make them slow again in the future --> users \
> will observe performance drop ;)
> Sebastian Kügler wrote:
> That's a pretty weak argument. "Let's keep rubbish in that isn't used, so when we use it, \
> it's as slow as it's now and nobody will notice that we added stuff and slowed it down", \
> essentially. :D
> The agenda part should be optional in the code, perhaps show / hide dynamically, based on \
> whether the user wants or as agenda items. These are quite complex bits of UI, the \
> lazy-loading helps, but we should still attempt to make it not load stuff that isn't \
> necessary.
> So let's do it right.
Ah, btw ... commenting stuff all around is not needed: You can just check within the code if \
references are valid and make it conditional, that's more future-proof as well.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/#review58808
-----------------------------------------------------------
On May 27, 2014, 4 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118357/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 4 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda \
> backend and should just be hidden. Here's a patch simply hiding the left part - it's easier \
> to do just "visible: false" than comment it out and then comment out/remove all the lines \
> referencing parts of the agenda, also cleaner.
> I added a big comment at the file beginning, I'll fill the commit sha after committing so it \
> can be easily reverted (the comment will be separate commit).
> Screenshot attached.
>
> Oh and you might want to remove the clock from panel and readd it/remove plasma config as the \
> popup size seems to be saved and so after this patch you may still get the original-sized \
> half-empty dialog.
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4
>
> Diff: https://git.reviewboard.kde.org/r/118357/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Calendar without agenda
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118357/">https://git.reviewboard.kde.org/r/118357/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2014, 1:27 p.m. UTC, <b>Sebastian Kügler</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Since the visible flag is now static false, \
let's comment the agenda item code, so we don't waste memory or CPU cycles. Once done, \
please ship.</pre> </blockquote>
<p>On May 30th, 2014, 1:31 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I specifically opted out of commenting it as \
that would mean commenting stuff all around (stuff that references the commented out stuff). If \
really needed, I can do tho. On the other hand, if this is to make things faster, it will make \
them slow again in the future --> users will observe performance drop ;)</pre> \
</blockquote>
<p>On May 30th, 2014, 1:52 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">That's a pretty weak argument. \
"Let's keep rubbish in that isn't used, so when we use it, it's as slow as \
it's now and nobody will notice that we added stuff and slowed it down", essentially. \
:D
The agenda part should be optional in the code, perhaps show / hide dynamically, based on \
whether the user wants or as agenda items. These are quite complex bits of UI, the lazy-loading \
helps, but we should still attempt to make it not load stuff that isn't necessary.
So let's do it right.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ah, btw ... commenting stuff all around is \
not needed: You can just check within the code if references are valid and make it conditional, \
that's more future-proof as well.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On May 27th, 2014, 4 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 4 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As agreed on irc \
(someday ago), the agenda part is useless until there's a proper agenda backend and should \
just be hidden. Here's a patch simply hiding the left part - it's easier to do just \
"visible: false" than comment it out and then comment out/remove all the lines \
referencing parts of the agenda, also cleaner.
I added a big comment at the file beginning, I'll fill the commit sha after committing so \
it can be easily reverted (the comment will be separate commit).
Screenshot attached.
Oh and you might want to remove the clock from panel and readd it/remove plasma config as the \
popup size seems to be saved and so after this patch you may still get the original-sized \
half-empty dialog.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: \
grey">(43812a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118357/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png">Calendar \
without agenda</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic