'Re: Review Request 118424: [klipper] Port away from KSessionManager'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118424: [klipper] Port away from KSessionManager
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-05-30 13:28:16
Message-ID: 20140530132816.14701.12633 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On May 30, 2014, 3:21 p.m., David Edmundson wrote:
> > Current behaviour is if you have something in your clipboard on closing, it will \
> > be there when you restart. Can you confirm this still works before shipping.

sure, steps done:
1. recompiled and installed klipper
2. stopped running klipper
3. started new klipper
4. added a new entry to klipper
5. verified it's there
6. stoppe klipper
7. started klipper
8. verified it's still there \o/

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118424/#review58805
-----------------------------------------------------------

On May 30, 2014, 3:18 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118424/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 3:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port away from KSessionManager
> 
> 
> Diffs
> -----
> 
> klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 
> klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d 
> 
> Diff: https://git.reviewboard.kde.org/r/118424/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118424/">https://git.reviewboard.kde.org/r/118424/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 30th, 2014, 3:21 p.m. CEST, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current behaviour is if you have something in your clipboard on closing, \
it will be there when you restart. Can you confirm this still works before \
shipping.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure, steps done: 1. \
recompiled and installed klipper 2. stopped running klipper
3. started new klipper
4. added a new entry to klipper
5. verified it&#39;s there
6. stoppe klipper
7. started klipper
8. verified it&#39;s still there \o/</pre>
<br />

<p>- Martin</p>

<br />
<p>On May 30th, 2014, 3:18 p.m. CEST, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 30, 2014, 3:18 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port away from KSessionManager</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>klipper/klipper.h <span style="color: \
grey">(3a204bb764d24c24bfc4d4aae759a52c510b7b33)</span></li>

 <li>klipper/klipper.cpp <span style="color: \
grey">(ad2855c6e91d2ef659a6a7f341b060181766d66d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118424/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 