From kde-panel-devel Fri May 30 12:12:23 2014 From: "Eike Hein" Date: Fri, 30 May 2014 12:12:23 +0000 To: kde-panel-devel Subject: Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and a Message-Id: <20140530121223.2659.39466 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140145196603784 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0069568978674646212==" --===============0069568978674646212== Content-Type: multipart/alternative; boundary="===============6811645013279733018==" --===============6811645013279733018== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ ----------------------------------------------------------- (Updated May 30, 2014, 12:12 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Marco Martin. Repository: plasma-workspace Description ------- This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author. A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components. Diffs ----- wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941 wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b Diff: https://git.reviewboard.kde.org/r/118419/diff/ Testing ------- File Attachments ---------------- Example tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png Thanks, Eike Hein --===============6811645013279733018== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/

This change has been marked as submitted.

Review request for Plasma and Marco Martin.
By Eike Hein.

Updated May 30, 2014, 12:12 p.m.

Repository: plasma-workspace

Description 

This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author.

A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components.

Diffs

  • wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml (c139941)
  • wallpapers/image/imagepackage/contents/ui/config.qml (9f1602b)

View Diff

File Attachments

--===============6811645013279733018==-- --===============0069568978674646212== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0069568978674646212==--