[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118413: Put the settings views in a ScrollView
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-05-30 10:42:50
Message-ID: 20140530104250.14701.87581 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/#review58778
-----------------------------------------------------------
Ship it!
desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40897>
is large/2 not just "small" ?
desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40896>
remove this debug info
desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40898>
I'm not 100% convinced by this, it means a text label won't wrap as that can have \
a huge implicitWidth.
Lets only make it grow vertically.
- David Edmundson
On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118413/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 12:41 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> So far, if the page didn't fit the view, it wouldn't react or anything and it would \
> just cut the contents out. With this change it will show scrollbars so it can be \
> reached, if it's needed.
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a
>
> Diff: https://git.reviewboard.kde.org/r/118413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118413/">https://git.reviewboard.kde.org/r/118413/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line224" \
style="color: black; font-weight: bold; text-decoration: \
underline;">desktoppackage/contents/configuration/AppletConfiguration.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">224</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">spacing:</span> <span class="nx">units</span><span \
class="p">.</span><span class="nx">largeSpacing</span> <span class="o">/</span> <span \
class="mi">2</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is large/2 \
not just "small" ?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line237" \
style="color: black; font-weight: bold; text-decoration: \
underline;">desktoppackage/contents/configuration/AppletConfiguration.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">236</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">Text</span> <span class="p">{</span> <span class="k">text:</span> \
<span class="nx">main</span><span class="p">.</span><span \
class="nx">width</span><span class="o">+</span><span class="s2">" --- \
"</span> <span class="o">+</span><span class="nx">scroll</span><span \
class="p">.</span><span class="nx">width</span> <span class="o">+</span> <span \
class="s2">" "</span> <span class="o">+</span> <span \
class="nx">main</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">implicitWidth</span><span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove this \
debug info</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line250" \
style="color: black; font-weight: bold; text-decoration: \
underline;">desktoppackage/contents/configuration/AppletConfiguration.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">245</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">width:</span> <span class="nb">Math</span><span \
class="p">.</span><span class="nx">max</span><span class="p">(</span><span \
class="nx">scroll</span><span class="p">.</span><span class="nx">viewport</span><span \
class="p">.</span><span class="nx">width</span><span class="p">,</span> <span \
class="nx">main</span><span class="p">.</span><span \
class="nx">currentItem</span><span class="p">.</span><span \
class="nx">implicitWidth</span> <span class="o">?</span> <span \
class="k">main.currentItem.implicitWidth :</span> <span class="nx">main</span><span \
class="p">.</span><span class="nx">currentItem</span><span class="p">.</span><span \
class="nx">childrenRect</span><span class="p">.</span><span \
class="nx">width</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not \
100% convinced by this, it means a text label won't wrap as that can have a huge \
implicitWidth.
Lets only make it grow vertically.
</pre>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On May 30th, 2014, 12:41 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated May 30, 2014, 12:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">So far, if the page didn't fit the view, it wouldn't react or \
anything and it would just cut the contents out. With this change it will show \
scrollbars so it can be reached, if it's needed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/configuration/AppletConfiguration.qml <span \
style="color: grey">(ea6010a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118413/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic