[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-05-30 9:50:54
Message-ID: 20140530095054.14701.4800 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/#review58772
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 30, 2014, 6:54 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118414/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 6:54 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> [killer] Use dialog-warning icon as window icon for killer
>
> Based on the discussion on kwin [1] and plasma-devel [2] mailing list.
>
> [1] http://lists.kde.org/?l=kwin&m=140119827404150&w=2
> [2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html
>
>
> Diffs
> -----
>
> killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25
>
> Diff: https://git.reviewboard.kde.org/r/118414/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Killer with warning icon
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118414/">https://git.reviewboard.kde.org/r/118414/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On May 30th, 2014, 6:54 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 30, 2014, 6:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[killer] Use dialog-warning icon as window icon for killer
Based on the discussion on kwin [1] and plasma-devel [2] mailing list.
[1] http://lists.kde.org/?l=kwin&m=140119827404150&w=2
[2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>killer/killer.cpp <span style="color: \
grey">(0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118414/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png">Killer \
with warning icon</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic