[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118251: Small improvments to FadingNode and IconItem
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-05-29 15:11:48
Message-ID: 20140529151148.2659.44889 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 22, 2014, 10:02 a.m., David Edmundson wrote:
> > src/declarativeimports/core/fadingnode.cpp, line 87
> > <https://git.reviewboard.kde.org/r/118251/diff/1/?file=274043#file274043line87>
> >
> > Now it will animate backwards?
> >
> > Unless you change the vertex shader too.
>
> Martin Gräßlin wrote:
> this is really confusing. Why is there a check on target changed and then source \
> gets bound? I might have gotten that wrong but it looked strange. Could you please \
> elaborate on how that's supposed to work?
> David Edmundson wrote:
> Oooh! You're right. Clearly something is off.
>
> I think we might have to then swap round tex1 and tex2 in this line:
> gl_FragColor.a = mix(tex1.a, tex2.a,
>
> before submitting could you try it on a super slow animation and check it still \
> animates correctly
> Martin Gräßlin wrote:
> no, I cannot animate at all, see \
> https://bugreports.qt-project.org/browse/QTBUG-39182
I tested this, you do need to swap round tex1 and text2 in my mix line in the shader.
You can either do that and ship it, or I can ship for yoU?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review58275
-----------------------------------------------------------
On May 22, 2014, 6:02 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118251/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 6:02 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Small improvments to FadingNode and IconItem
>
> * trigger an update after the animation finished as the IconItem needs to
> switch to SVGTextureNode again
> * Don't connect needlessly to a lambda slot
> * FadingMaterialShader had the texture bind swapped
> * Fix virtual method hidden warning in FadingMaterialShader
> * Use dynamic_cast instead of static_cast to convert to SVGTextureNode
> or FadingNode.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/fadingnode.cpp 207eff3902848a3c76bf1ec62d73877d6d9d0df7 \
> src/declarativeimports/core/iconitem.cpp bdf5e286c9bff3ebd0b124f1593de63ed4232515
>
> Diff: https://git.reviewboard.kde.org/r/118251/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118251/">https://git.reviewboard.kde.org/r/118251/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 22nd, 2014, 10:02 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118251/diff/1/?file=274043#file274043line87" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/core/fadingnode.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const \
char* FadingMaterialShader::fragmentShader() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">86</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">newState</span><span class="o">-></span><span class="n"><span \
class="hl">target</span></span><span class="o">-></span><span \
class="n">bind</span><span class="p">();</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">87</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">newState</span><span class="o">-></span><span class="n"><span \
class="hl">source</span></span><span class="o">-></span><span \
class="n">bind</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now it will animate \
backwards?
Unless you change the vertex shader too.</pre>
</blockquote>
<p>On May 22nd, 2014, 10:06 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is really \
confusing. Why is there a check on target changed and then source gets bound? I might \
have gotten that wrong but it looked strange. Could you please elaborate on how \
that's supposed to work?</pre> </blockquote>
<p>On May 22nd, 2014, 10:14 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oooh! You're right. \
Clearly something is off.
I think we might have to then swap round tex1 and tex2 in this line:
gl_FragColor.a = mix(tex1.a, tex2.a,
before submitting could you try it on a super slow animation and check it still \
animates correctly</pre> </blockquote>
<p>On May 22nd, 2014, 10:17 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, I cannot animate at \
all, see https://bugreports.qt-project.org/browse/QTBUG-39182</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested \
this, you do need to swap round tex1 and text2 in my mix line in the shader.
You can either do that and ship it, or I can ship for yoU?</pre>
<br />
<p>- David</p>
<br />
<p>On May 22nd, 2014, 6:02 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 22, 2014, 6:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Small improvments to FadingNode and IconItem
* trigger an update after the animation finished as the IconItem needs to
switch to SVGTextureNode again
* Don't connect needlessly to a lambda slot
* FadingMaterialShader had the texture bind swapped
* Fix virtual method hidden warning in FadingMaterialShader
* Use dynamic_cast instead of static_cast to convert to SVGTextureNode
or FadingNode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/fadingnode.cpp <span style="color: \
grey">(207eff3902848a3c76bf1ec62d73877d6d9d0df7)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(bdf5e286c9bff3ebd0b124f1593de63ed4232515)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118251/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic