'Re: Review Request 118382: [klipper] Fix i18n'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118382: [klipper] Fix i18n
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-05-29 14:20:37
Message-ID: 20140529142037.14701.28648 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118382/#review58723
-----------------------------------------------------------

Ship it!

I'm not very happy giving a ship it to something that is ported but completely \
untested. We end up with code we think works, but doesn't work properly; which is \
worse than not touching it at all.

It should be possible to download the x-test translations? Lets ask i18n if we need \
to.

- David Edmundson

On May 28, 2014, 3:22 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118382/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 3:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Fix i18n
> 
> 
> Diffs
> -----
> 
> klipper/CMakeLists.txt 7a57b30b8b59a77c3d0702095dd72bb275d22e57 
> klipper/main.cpp 153a03160717431eaaa95e77903ab43de9b07fcb 
> 
> Diff: https://git.reviewboard.kde.org/r/118382/diff/
> 
> 
> Testing
> -------
> 
> I still don't know how to test i18n with kf5 :-)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118382/">https://git.reviewboard.kde.org/r/118382/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not very happy \
giving a ship it to something that is ported but completely untested. We end up with \
code we think works, but doesn&#39;t work properly; which is worse than not touching \
it at all.

It should be possible to download the x-test translations? Lets ask i18n if we need \
to.</pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On May 28th, 2014, 3:22 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 28, 2014, 3:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Fix i18n</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I still don&#39;t know how to test i18n with kf5 :-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>klipper/CMakeLists.txt <span style="color: \
grey">(7a57b30b8b59a77c3d0702095dd72bb275d22e57)</span></li>

 <li>klipper/main.cpp <span style="color: \
grey">(153a03160717431eaaa95e77903ab43de9b07fcb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118382/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 