'Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2014-05-29 11:39:32
Message-ID: 20140529113932.1538.93673 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118155/#review58704
-----------------------------------------------------------

Ship it!

Builds and tests pass for me on Linux. I think we don't need the NAME_PREFIX \
arguments any more, but I'll wait to see what people think of \
https://git.reviewboard.kde.org/r/118385/ first.

- Alex Merry

On May 15, 2014, 3 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118155/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 3 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> adapt to ecm_add_tests so that tests can be found
> 
> 
> Diffs
> -----
> 
> autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 
> 
> Diff: https://git.reviewboard.kde.org/r/118155/diff/
> 
> 
> Testing
> -------
> 
> mingw
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118155/">https://git.reviewboard.kde.org/r/118155/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and tests pass \
for me on Linux. I think we don&#39;t need the NAME_PREFIX arguments any more, but \
I&#39;ll wait to see what people think of https://git.reviewboard.kde.org/r/118385/ \
first.</pre>  <br />

<p>- Alex Merry</p>

<br />
<p>On May 15th, 2014, 3 p.m. UTC, Patrick Spendrin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kdewin and Plasma.</div>
<div>By Patrick Spendrin.</div>

<p style="color: grey;"><i>Updated May 15, 2014, 3 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">adapt to ecm_add_tests so that tests can be found</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">mingw</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: \
grey">(dcee37f0771753d3e381e9d77f351cff16531e93)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118155/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 