[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118381: [klipper] Reintroduce the dependency on prison
From: "Johannes Huber" <johu () gentoo ! org>
Date: 2014-05-28 21:18:21
Message-ID: 20140528211821.27790.79897 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 28, 2014, 11:16 p.m., Johannes Huber wrote:
> > Ship It!
Good job. Compiled with and without prison. Quick runtime test: OK.
- Johannes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118381/#review58688
-----------------------------------------------------------
On May 28, 2014, 4:49 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118381/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 4:49 p.m.)
>
>
> Review request for Plasma and Johannes Huber.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [klipper] Port Barcode dialog from KDialog to QDialog
>
>
> [klipper] Reintroduce the dependency on prison
>
>
> Diffs
> -----
>
> klipper/CMakeLists.txt 7a57b30b8b59a77c3d0702095dd72bb275d22e57
> klipper/klipper.cpp 1ce578afb078b3b4e791e780975802082559bdf4
>
> Diff: https://git.reviewboard.kde.org/r/118381/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118381/">https://git.reviewboard.kde.org/r/118381/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 28th, 2014, 11:16 p.m. CEST, <b>Johannes \
Huber</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good job. Compiled with \
and without prison. Quick runtime test: OK.</pre> <br />
<p>- Johannes</p>
<br />
<p>On May 28th, 2014, 4:49 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Johannes Huber.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 4:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port Barcode dialog from KDialog to QDialog
[klipper] Reintroduce the dependency on prison</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/CMakeLists.txt <span style="color: \
grey">(7a57b30b8b59a77c3d0702095dd72bb275d22e57)</span></li>
<li>klipper/klipper.cpp <span style="color: \
grey">(1ce578afb078b3b4e791e780975802082559bdf4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118381/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic