From kde-panel-devel Wed May 28 14:24:22 2014 From: "David Edmundson" Date: Wed, 28 May 2014 14:24:22 +0000 To: kde-panel-devel Subject: Re: Review Request 118376: Remove unnecessary placeholder Message-Id: <20140528142422.27790.70799 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140128708102324 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8502536677017217380==" --===============8502536677017217380== Content-Type: multipart/alternative; boundary="===============2827252614239220385==" --===============2827252614239220385== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118376/ ----------------------------------------------------------- (Updated May 28, 2014, 2:24 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- Remove unnecessary placeholder Text.implicitWidth holds the size the text would be if it wasn't truncated + fix wrapping of subtext parent.preferredTextWidth was undefined, so nothing wrapped. Diffs ----- src/declarativeimports/core/private/DefaultToolTip.qml 4634d74 tests/tooltip.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118376/diff/ Testing ------- Added a whole new test QML file. Thanks, David Edmundson --===============2827252614239220385== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118376/

This change has been marked as submitted.

Review request for Plasma.

By David Edmundson.

Updated May 28, 2014, 2:24 p.m.

Repository: plasma-framework

Description

Remove unnecessary placeholder

Text.implicitWidth holds the size the text would be if it wasn't
truncated


+ fix wrapping of subtext
parent.preferredTextWidth was undefined, so nothing wrapped.

Testing

Added a whole new test QML file.

Diffs

src/declarativeimports/core/private/DefaultToolTip.qml (4634d74)
tests/tooltip.qml (PRE-CREATION)

View Diff

--===============2827252614239220385==-- --===============8502536677017217380== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8502536677017217380==--