--===============3424930545123160967== Content-Type: multipart/alternative; boundary="===============2303669035991528675==" --===============2303669035991528675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109160/ ----------------------------------------------------------- (Updated May 28, 2014, 12:32 p.m.) Status ------ This change has been discarded. Review request for Plasma. Repository: kde-workspace Description ------- Show all help options KRunner's resultview limits the numer of items shown to 50. This makes sense when showing runner results, but it also cuts off the list of help options, making it incomplete. Suggested patch adds a parameter to ResultScene::setQueryMatches(...) which allows overriding the behaviour, and makes setting the help options use this. Intended for 4.10 and master. Diffs ----- krunner/interfaces/default/resultscene.cpp 514c2c8 krunner/interfaces/default/resultscene.h 4aa4844 krunner/interfaces/default/interface.cpp 505e0aa Diff: https://git.reviewboard.kde.org/r/109160/diff/ Testing ------- Verified that all help options are shown. No visible side-effects. Thanks, Sebastian Kügler --===============2303669035991528675== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109160/

This change has been discarded.


Review request for Plasma.
By Sebastian Kügler.

Updated May 28, 2014, 12:32 p.m.

Repository: kde-workspace

Description

Show all help options

KRunner's resultview limits the numer of items shown to 50. This makes
sense when showing runner results, but it also cuts off the list of help
options, making it incomplete.

Suggested patch adds a parameter to ResultScene::setQueryMatches(...)
which allows overriding the behaviour, and makes setting the help
options use this.

Intended for 4.10 and master.

Testing

Verified that all help options are shown. No visible side-effects.

Diffs

  • krunner/interfaces/default/resultscene.cpp (514c2c8)
  • krunner/interfaces/default/resultscene.h (4aa4844)
  • krunner/interfaces/default/interface.cpp (505e0aa)

View Diff

--===============2303669035991528675==-- --===============3424930545123160967== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3424930545123160967==--