'Re: Review Request 118367: Fix activities data engine by exporting toggleActivityManager method over'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118367: Fix activities data engine by exporting toggleActivityManager method over
From:       "Commit Hook" <null () kde ! org>
Date:       2014-05-28 10:32:15
Message-ID: 20140528103215.27790.95764 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118367/#review58641
-----------------------------------------------------------

This review has been submitted with commit cc3ab5e0f413e4b2ab0fe39e3590024683c8a4b1 \
by Bhushan Shah to branch master.

- Commit Hook

On May 28, 2014, 5:31 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118367/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 5:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335427
> https://bugs.kde.org/show_bug.cgi?id=335427
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix activities data engine by exporting toggleActivityManager method over DBus.
> 
> 
> Diffs
> -----
> 
> dataengines/activities/activityjob.cpp fab23ba 
> shell/dbus/org.kde.PlasmaShell.xml 0b26526 
> shell/shellcorona.h 0d4e462 
> 
> Diff: https://git.reviewboard.kde.org/r/118367/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbusviewer, plasmaengineexplorer and Activities applet.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118367/">https://git.reviewboard.kde.org/r/118367/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cc3ab5e0f413e4b2ab0fe39e3590024683c8a4b1 by Bhushan Shah to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On May 28th, 2014, 5:31 a.m. UTC, Bhushan Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated May 28, 2014, 5:31 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=335427">335427</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix activities data engine by exporting toggleActivityManager method \
over DBus.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with qdbusviewer, plasmaengineexplorer and Activities \
applet.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dataengines/activities/activityjob.cpp <span style="color: \
grey">(fab23ba)</span></li>

 <li>shell/dbus/org.kde.PlasmaShell.xml <span style="color: \
grey">(0b26526)</span></li>

 <li>shell/shellcorona.h <span style="color: grey">(0d4e462)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118367/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 