[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 105312: Add missing email addresses back into add widget tooltip.
From: "Matthew Dawson" <matthew () mjdsystems ! ca>
Date: 2014-05-27 18:27:47
Message-ID: 20140527182747.21363.95880 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105312/
-----------------------------------------------------------
(Updated May 27, 2014, 2:27 p.m.)
Status
------
This change has been discarded.
Review request for Plasma, Ivan Čukić and Marco Martin.
Repository: kde-workspace
Description
-------
When the QML port of the add widget dialog occured, the creator's email address got \
chopped off. This commit fixes a bug hidding the email address, and also starts \
displaying it again in the tooltip.
There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for no reason \
(it fits fine otherwise). 2) The link currently doesn't work as I'm not sure how to \
hook it up to send mail. Should it be left as is, or just remove the link for 4.9 \
and update with a link for 4.10?
Diffs
-----
libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml \
ba804fd006496ee4a7118e97fe44038f0617eec7 \
libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h \
e745ef58533ab0e22d2109d5beeff6c29c4d18b4
Diff: https://git.reviewboard.kde.org/r/105312/diff/
Testing
-------
Tested locally in Xephyr. The tooltip now contains the email address.
Thanks,
Matthew Dawson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/105312/">https://git.reviewboard.kde.org/r/105312/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Ivan Čukić and Marco Martin.</div>
<div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated May 27, 2014, 2:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the QML port of the add widget dialog occured, the creator's \
email address got chopped off. This commit fixes a bug hidding the email address, \
and also starts displaying it again in the tooltip.
There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for no reason \
(it fits fine otherwise). 2) The link currently doesn't work as I'm not sure \
how to hook it up to send mail. Should it be left as is, or just remove the link for \
4.9 and update with a link for 4.10?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested locally in Xephyr. The tooltip now contains the email \
address.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml <span \
style="color: grey">(ba804fd006496ee4a7118e97fe44038f0617eec7)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h <span \
style="color: grey">(e745ef58533ab0e22d2109d5beeff6c29c4d18b4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/105312/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic