'Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-05-27 13:57:26
Message-ID: 20140527135726.21300.37484 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On May 27, 2014, 3:52 p.m., Martin Klapetek wrote:
> > > Unfortunately this way we cannot have a plural aware suffix.
> > 
> > What if you do this from code like "setSuffix(i18np("signular", "plural", \
> > value));" ?
> 
> Martin Klapetek wrote:
> Oh but that's not a binding so it won't auto update...too much time in QML xD
> 
> Nevermind.

I hoped there is a better solution, which I'm just not aware of :-) It would need a \
connect to update the suffix whenever the value changes, which was the reason I \
didn't implement that one.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58567
-----------------------------------------------------------

On May 27, 2014, 2:04 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -----
> 
> klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
> klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118347/">https://git.reviewboard.kde.org/r/118347/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 27th, 2014, 3:52 p.m. CEST, <b>Martin \
Klapetek</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&gt; Unfortunately this way we cannot have a plural aware suffix.

What if you do this from code like &quot;setSuffix(i18np(&quot;signular&quot;, \
&quot;plural&quot;, value));&quot; ?</pre>  </blockquote>

 <p>On May 27th, 2014, 3:57 p.m. CEST, <b>Martin Klapetek</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh but that&#39;s not a \
binding so it won&#39;t auto update...too much time in QML xD

Nevermind.</pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I hoped there is a \
better solution, which I&#39;m just not aware of :-) It would need a connect to \
update the suffix whenever the value changes, which was the reason I didn&#39;t \
implement that one.</pre> <br />

<p>- Martin</p>

<br />
<p>On May 27th, 2014, 2:04 p.m. CEST, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 27, 2014, 2:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port from KIntSpinBox to QSpinBox

Unfortunately this way we cannot have a plural aware suffix.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>klipper/configdialog.cpp <span style="color: \
grey">(15901992db8d6fe28d800c4a18a3a6529cace1be)</span></li>

 <li>klipper/generalconfig.ui <span style="color: \
grey">(f0145752eb2dbd927392b682b6472695c793a588)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118347/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 