'Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor
From:       "Antonis Tsiapaliokas" <antonis.tsiapaliokas () kde ! org>
Date:       2014-05-27 11:27:26
Message-ID: 20140527112726.21363.57253 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118254/
-----------------------------------------------------------

(Updated May 27, 2014, 11:27 a.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: plasma-framework

Description
-------

hello,

This patch adds a new interceptor for our shell packages.
Right now we cannot load an svg if the image is inside the /contents/images of the shell package.
So this patch solves that issue.

Diffs
-----

  src/plasma/private/packages.cpp fa0fc6a 
  src/plasmaquick/CMakeLists.txt cc5554a 
  src/plasmaquick/shellurlinterceptor.h PRE-CREATION 
  src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION 
  src/plasmaquick/view.cpp 5aa1102 

Diff: https://git.reviewboard.kde.org/r/118254/diff/

Testing
-------

*Testing*
org.kde.desktop shell package works without any issue.

*Issues*

The interceptor doesn't return a scheme for the svg component.

PlasmaCore.SvgItem {
    svg: PlasmaCore.Svg {
        imagePath: "shellpackage:/images/bar.svgz"
    }
}

On the above code, the "path.scheme()" from the interceptor never returns
"shellpackage", so it is completely ignored.

But the following one it works

Image {
    source: "shellpackage:/images/foo.png"
}

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118254/">https://git.reviewboard.kde.org/r/118254/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated May 27, 2014, 11:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

This patch adds a new interceptor for our shell packages.
Right now we cannot load an svg if the image is inside the /contents/images of the \
shell package. So this patch solves that issue.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">*Testing* org.kde.desktop shell package works without any issue.

*Issues*

The interceptor doesn&#39;t return a scheme for the svg component.

PlasmaCore.SvgItem {
    svg: PlasmaCore.Svg {
        imagePath: &quot;shellpackage:/images/bar.svgz&quot;
    }
}

On the above code, the &quot;path.scheme()&quot; from the interceptor never returns
&quot;shellpackage&quot;, so it is completely ignored.

But the following one it works

Image {
    source: &quot;shellpackage:/images/foo.png&quot;
}</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/private/packages.cpp <span style="color: grey">(fa0fc6a)</span></li>

 <li>src/plasmaquick/CMakeLists.txt <span style="color: grey">(cc5554a)</span></li>

 <li>src/plasmaquick/shellurlinterceptor.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plasmaquick/shellurlinterceptor.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plasmaquick/view.cpp <span style="color: grey">(5aa1102)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118254/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 