[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118290: Streamline Comment fields of KCMs
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-05-26 23:34:17
Message-ID: 20140526233417.28658.91283 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118290/#review58531
-----------------------------------------------------------
kcms/hardware/display/display.desktop
<https://git.reviewboard.kde.org/r/118290/#comment40737>
&
- Christoph Feck
On May 26, 2014, 10:52 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118290/
> -----------------------------------------------------------
>
> (Updated May 26, 2014, 10:52 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Streamline Comment fields of KCMs
>
> This patch applies a common language and type-setting to the
> systemsettings modules in kde-workspace.
>
> Considerations:
> - The comment field might repeat the name, or give more detail about the
> specific settings on this page, this makes sense with how
> systemsettings and kcmshell present it
> - Mentioning the words settings, configure, options, etc. is avoided --
> it is clear from the context that these are settings and options.
> - Title-case throughout in line with human interface guidelines, see
> http://techbase.kde.org/Projects/Usability/HIG/Capitalization
> - The comment ends up being the title, so the
> - tech slang is avoided as much as possible, but left in where really
> necessary (hi Phonon), there were a few mentions of ~"KDE Settings",
> which don't make sense in a properly branded universe.
> - I've left the Name field "mostly untouched", as that one is key for
> the user to find the right module in systemsettings' icon view and in
> the sidebars
>
> The same treatment needs to be done for a bunch of other KCMs that we
> end up installing from other repos. This is a good start, however.
>
>
> Diffs
> -----
>
> kcms/access/kcmaccess.desktop f859504
> kcms/autostart/autostart.desktop 5a1048e
> kcms/bell/bell.desktop 906aff7
> kcms/colors/colors.desktop 409f665
> kcms/componentchooser/componentchooser.desktop 214c4f1
> kcms/dateandtime/clock.desktop acaca1a
> kcms/desktoppaths/desktoppath.desktop da351d9
> kcms/desktoptheme/desktoptheme.desktop 602f04c
> kcms/emoticons/emoticons.desktop bbbd24a
> kcms/fonts/fonts.desktop 99a88c4
> kcms/formats/formats.desktop 8a95b61
> kcms/hardware/display/display.desktop 0d8b7e6
> kcms/hardware/joystick/joystick.desktop e5ff24a
> kcms/icons/icons.desktop 1dfcf8c
> kcms/input/cursortheme.desktop 4a5feed
> kcms/input/mouse.desktop 5df856e
> kcms/kded/kcmkded.desktop 76e299d
> kcms/keyboard/kcm_keyboard.desktop 01f9542
> kcms/keys/keys.desktop 30a4bc8
> kcms/kfontinst/kcmfontinst/fontinst.desktop 6b13725
> kcms/knotify/kcmnotify.desktop cd25cd4
> kcms/ksmserver/kcmsmserver.desktop c461be7
> kcms/ksplash/ksplashthememgr.desktop 711fbc3
> kcms/launch/kcmlaunch.desktop fbb3ca6
> kcms/phonon/kcm_phonon.desktop 46eecff
> kcms/spellchecking/spellchecking.desktop 92a76cf
> kcms/standard_actions/standard_actions.desktop 54a3ea8
> kcms/style/style.desktop fd19bc4
> kcms/workspaceoptions/workspaceoptions.desktop 3e31866
>
> Diff: https://git.reviewboard.kde.org/r/118290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastian Kügler
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118290/">https://git.reviewboard.kde.org/r/118290/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118290/diff/2/?file=275184#file275184line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/hardware/display/display.desktop</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">Comment=Display<span \
class="hl"> Setting</span>s</pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">100</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">Comment=Display<span class="hl">s & \
Monitor</span>s</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&</pre> \
</div> <br />
<p>- Christoph Feck</p>
<br />
<p>On May 26th, 2014, 10:52 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 10:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Streamline Comment fields of KCMs
This patch applies a common language and type-setting to the
systemsettings modules in kde-workspace.
Considerations:
- The comment field might repeat the name, or give more detail about the
specific settings on this page, this makes sense with how
systemsettings and kcmshell present it
- Mentioning the words settings, configure, options, etc. is avoided --
it is clear from the context that these are settings and options.
- Title-case throughout in line with human interface guidelines, see
http://techbase.kde.org/Projects/Usability/HIG/Capitalization
- The comment ends up being the title, so the
- tech slang is avoided as much as possible, but left in where really
necessary (hi Phonon), there were a few mentions of ~"KDE Settings",
which don't make sense in a properly branded universe.
- I've left the Name field "mostly untouched", as that one is key for
the user to find the right module in systemsettings' icon view and in
the sidebars
The same treatment needs to be done for a bunch of other KCMs that we
end up installing from other repos. This is a good start, however.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/access/kcmaccess.desktop <span style="color: grey">(f859504)</span></li>
<li>kcms/autostart/autostart.desktop <span style="color: grey">(5a1048e)</span></li>
<li>kcms/bell/bell.desktop <span style="color: grey">(906aff7)</span></li>
<li>kcms/colors/colors.desktop <span style="color: grey">(409f665)</span></li>
<li>kcms/componentchooser/componentchooser.desktop <span style="color: \
grey">(214c4f1)</span></li>
<li>kcms/dateandtime/clock.desktop <span style="color: grey">(acaca1a)</span></li>
<li>kcms/desktoppaths/desktoppath.desktop <span style="color: \
grey">(da351d9)</span></li>
<li>kcms/desktoptheme/desktoptheme.desktop <span style="color: \
grey">(602f04c)</span></li>
<li>kcms/emoticons/emoticons.desktop <span style="color: grey">(bbbd24a)</span></li>
<li>kcms/fonts/fonts.desktop <span style="color: grey">(99a88c4)</span></li>
<li>kcms/formats/formats.desktop <span style="color: grey">(8a95b61)</span></li>
<li>kcms/hardware/display/display.desktop <span style="color: \
grey">(0d8b7e6)</span></li>
<li>kcms/hardware/joystick/joystick.desktop <span style="color: \
grey">(e5ff24a)</span></li>
<li>kcms/icons/icons.desktop <span style="color: grey">(1dfcf8c)</span></li>
<li>kcms/input/cursortheme.desktop <span style="color: grey">(4a5feed)</span></li>
<li>kcms/input/mouse.desktop <span style="color: grey">(5df856e)</span></li>
<li>kcms/kded/kcmkded.desktop <span style="color: grey">(76e299d)</span></li>
<li>kcms/keyboard/kcm_keyboard.desktop <span style="color: \
grey">(01f9542)</span></li>
<li>kcms/keys/keys.desktop <span style="color: grey">(30a4bc8)</span></li>
<li>kcms/kfontinst/kcmfontinst/fontinst.desktop <span style="color: \
grey">(6b13725)</span></li>
<li>kcms/knotify/kcmnotify.desktop <span style="color: grey">(cd25cd4)</span></li>
<li>kcms/ksmserver/kcmsmserver.desktop <span style="color: \
grey">(c461be7)</span></li>
<li>kcms/ksplash/ksplashthememgr.desktop <span style="color: \
grey">(711fbc3)</span></li>
<li>kcms/launch/kcmlaunch.desktop <span style="color: grey">(fbb3ca6)</span></li>
<li>kcms/phonon/kcm_phonon.desktop <span style="color: grey">(46eecff)</span></li>
<li>kcms/spellchecking/spellchecking.desktop <span style="color: \
grey">(92a76cf)</span></li>
<li>kcms/standard_actions/standard_actions.desktop <span style="color: \
grey">(54a3ea8)</span></li>
<li>kcms/style/style.desktop <span style="color: grey">(fd19bc4)</span></li>
<li>kcms/workspaceoptions/workspaceoptions.desktop <span style="color: \
grey">(3e31866)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic