[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118328: Add the current month name to the calendar component by default
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-05-26 14:48:42
Message-ID: 20140526144842.28658.36762 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 26, 2014, 4:43 p.m., Alexander Potashev wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 106
> > <https://git.reviewboard.kde.org/r/118328/diff/1/?file=275094#file275094line106>
> >
> > Isn't adding of a fixed string (", ") a word puzzle?
> >
> > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles
> >
Kinda. I'm thinking about getting rid of that part, constructing proper date out of \
it and having it fully formatted by QLocale...
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118328/#review58488
-----------------------------------------------------------
On May 26, 2014, 4:25 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118328/
> -----------------------------------------------------------
>
> (Updated May 26, 2014, 4:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Currently we have 3 applets using the calendar grid and all of them put the extra \
> heading to the calendar. We also offer ways to change the displayed month so we \
> should also show /which/ month is the current one displayed, implicitly.
> I'll remove the special headers from the plasmoids afterwards.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/MonthView.qml 706952b
>
> Diff: https://git.reviewboard.kde.org/r/118328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118328/">https://git.reviewboard.kde.org/r/118328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 26th, 2014, 4:43 p.m. CEST, <b>Alexander \
Potashev</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118328/diff/1/?file=275094#file275094line106" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/qml/MonthView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">text:</span> <span class="nx">root</span><span class="p">.</span><span \
class="nx">startDate</span><span class="p">.</span><span \
class="nx">getFullYear</span><span class="p">()</span> <span class="o">==</span> \
<span class="k">new</span> <span class="nb">Date</span><span \
class="p">().</span><span class="nx">getFullYear</span><span class="p">()</span> \
<span class="o">?</span> <span class="k">root.selectedMonth :</span> <span \
class="nx">root</span><span class="p">.</span><span class="nx">selectedMonth</span> \
<span class="o">+</span> <span class="s2">", "</span> <span \
class="o">+</span> <span class="nx">root</span><span class="p">.</span><span \
class="nx">selectedYear</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't adding of a \
fixed string (", ") a word puzzle?
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kinda. \
I'm thinking about getting rid of that part, constructing proper date out of it \
and having it fully formatted by QLocale...</pre> <br />
<p>- Martin</p>
<br />
<p>On May 26th, 2014, 4:25 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 4:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently we have 3 applets using the calendar grid and all of them put \
the extra heading to the calendar. We also offer ways to change the displayed month \
so we should also show /which/ month is the current one displayed, implicitly.
I'll remove the special headers from the plasmoids afterwards.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(706952b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118328/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic