[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 116024: Port IconItem to native QSGTexture
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-05-13 10:50:01
Message-ID: 20140513105001.377.64255 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/
-----------------------------------------------------------
(Updated May 13, 2014, 10:50 a.m.)
Review request for Plasma.
Changes
-------
Updated
Repository: plasma-framework
Description
-------
Port IconItem to native QSGTexture including the animation.
This will save constantly uploading a new texture to OpenGL throughout the animation.
Diffs (updated)
-----
.reviewboardrc 804529c
CMakeLists.txt a726c75
src/declarativeimports/core/CMakeLists.txt 9b3313d
src/declarativeimports/core/fadingnode.cpp PRE-CREATION
src/declarativeimports/core/fadingnode_p.h PRE-CREATION
src/declarativeimports/core/iconitem.h 92a5233
src/declarativeimports/core/iconitem.cpp 9cb487c
Diff: https://git.reviewboard.kde.org/r/116024/diff/
Testing
-------
Test app: http://paste.kde.org/pl5pwdnel
Thanks,
David Edmundson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116024/">https://git.reviewboard.kde.org/r/116024/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated May 13, 2014, 10:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port IconItem to native QSGTexture including the animation. This will \
save constantly uploading a new texture to OpenGL throughout the animation.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test app: http://paste.kde.org/pl5pwdnel
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(804529c)</span></li>
<li>CMakeLists.txt <span style="color: grey">(a726c75)</span></li>
<li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(9b3313d)</span></li>
<li>src/declarativeimports/core/fadingnode.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/fadingnode_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/iconitem.h <span style="color: \
grey">(92a5233)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(9cb487c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116024/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic