[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117859: rename kioslave files for co-installability
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2014-05-08 20:18:42
Message-ID: 20140508201842.11253.60538 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117859/#review57608
-----------------------------------------------------------
at least to me looks good. only unsure should libmolletnetwork devel symlink, and \
interface file be installed at all? in 4.x world they come from kde-runtime, which is \
not used for development purposes...
- Hrvoje Senjan
On April 30, 2014, 11:36 a.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117859/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:36 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> rename kioslave files for co-installability
>
> ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
> network.xml -> kf5_network.xml
> org.kde.network.kioslavenotifier.xml -> kf5_org.kde.network.kioslavenotifier.xml (I \
> don't know what uses this but I assume something must and will need updated)
> old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/
>
>
> Diffs
> -----
>
> archive/tar.protocol 9442d4d
> bookmarks/bookmarks.protocol 68503d8
> cgi/cgi.protocol 862758a
> doc/kioslave/bookmarks/CMakeLists.txt d90f510
> doc/kioslave/bzip2/CMakeLists.txt 164ff50
> doc/kioslave/cgi/CMakeLists.txt 4474a13
> doc/kioslave/finger/CMakeLists.txt 54a06b0
> doc/kioslave/fish/CMakeLists.txt a711911
> doc/kioslave/floppy/CMakeLists.txt 601a7e8
> doc/kioslave/gzip/CMakeLists.txt 15d9a61
> doc/kioslave/info/CMakeLists.txt 3a4ace9
> doc/kioslave/man/CMakeLists.txt 7375332
> doc/kioslave/network/CMakeLists.txt 0921d20
> doc/kioslave/nfs/CMakeLists.txt 5d98ace
> doc/kioslave/sftp/CMakeLists.txt fe08290
> doc/kioslave/smb/CMakeLists.txt 906e945
> doc/kioslave/tar/CMakeLists.txt a699590
> doc/kioslave/thumbnail/CMakeLists.txt 555407d
> doc/kioslave/xz/CMakeLists.txt 731d519
> filter/bzip.protocol eceae18
> filter/bzip2.protocol 3db24ff
> filter/gzip.protocol b0fa2b3
> filter/lzma.protocol cdaa888
> filter/xz.protocol fc66e28
> finger/finger.protocol dda641b
> fish/fish.protocol fd577c8
> floppy/floppy.protocol cbd288a
> info/info.protocol c001580
> kurifilter-plugins/ikws/CMakeLists.txt 51294b5
> kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2
> man/man.protocol cd03f9f
> network/kded/CMakeLists.txt e851f73
> network/mimetypes/CMakeLists.txt c20dc90
> nfs/nfs.protocol 4781b3c
> sftp/sftp.protocol 6e49ed2
> smb/smb.protocol e15395e
> thumbnail/thumbnail.protocol 216f428
> trash/CMakeLists.txt 7c72cdc
>
> Diff: https://git.reviewboard.kde.org/r/117859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117859/">https://git.reviewboard.kde.org/r/117859/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">at least to me looks \
good. only unsure should libmolletnetwork devel symlink, and interface file be \
installed at all? in 4.x world they come from kde-runtime, which is not used for \
development purposes...</pre> <br />
<p>- Hrvoje Senjan</p>
<br />
<p>On April 30th, 2014, 11:36 a.m. CEST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 11:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rename kioslave files for co-installability
ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
network.xml -> kf5_network.xml
org.kde.network.kioslavenotifier.xml -> kf5_org.kde.network.kioslavenotifier.xml \
(I don't know what uses this but I assume something must and will need updated)
old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>archive/tar.protocol <span style="color: grey">(9442d4d)</span></li>
<li>bookmarks/bookmarks.protocol <span style="color: grey">(68503d8)</span></li>
<li>cgi/cgi.protocol <span style="color: grey">(862758a)</span></li>
<li>doc/kioslave/bookmarks/CMakeLists.txt <span style="color: \
grey">(d90f510)</span></li>
<li>doc/kioslave/bzip2/CMakeLists.txt <span style="color: \
grey">(164ff50)</span></li>
<li>doc/kioslave/cgi/CMakeLists.txt <span style="color: grey">(4474a13)</span></li>
<li>doc/kioslave/finger/CMakeLists.txt <span style="color: \
grey">(54a06b0)</span></li>
<li>doc/kioslave/fish/CMakeLists.txt <span style="color: grey">(a711911)</span></li>
<li>doc/kioslave/floppy/CMakeLists.txt <span style="color: \
grey">(601a7e8)</span></li>
<li>doc/kioslave/gzip/CMakeLists.txt <span style="color: grey">(15d9a61)</span></li>
<li>doc/kioslave/info/CMakeLists.txt <span style="color: grey">(3a4ace9)</span></li>
<li>doc/kioslave/man/CMakeLists.txt <span style="color: grey">(7375332)</span></li>
<li>doc/kioslave/network/CMakeLists.txt <span style="color: \
grey">(0921d20)</span></li>
<li>doc/kioslave/nfs/CMakeLists.txt <span style="color: grey">(5d98ace)</span></li>
<li>doc/kioslave/sftp/CMakeLists.txt <span style="color: grey">(fe08290)</span></li>
<li>doc/kioslave/smb/CMakeLists.txt <span style="color: grey">(906e945)</span></li>
<li>doc/kioslave/tar/CMakeLists.txt <span style="color: grey">(a699590)</span></li>
<li>doc/kioslave/thumbnail/CMakeLists.txt <span style="color: \
grey">(555407d)</span></li>
<li>doc/kioslave/xz/CMakeLists.txt <span style="color: grey">(731d519)</span></li>
<li>filter/bzip.protocol <span style="color: grey">(eceae18)</span></li>
<li>filter/bzip2.protocol <span style="color: grey">(3db24ff)</span></li>
<li>filter/gzip.protocol <span style="color: grey">(b0fa2b3)</span></li>
<li>filter/lzma.protocol <span style="color: grey">(cdaa888)</span></li>
<li>filter/xz.protocol <span style="color: grey">(fc66e28)</span></li>
<li>finger/finger.protocol <span style="color: grey">(dda641b)</span></li>
<li>fish/fish.protocol <span style="color: grey">(fd577c8)</span></li>
<li>floppy/floppy.protocol <span style="color: grey">(cbd288a)</span></li>
<li>info/info.protocol <span style="color: grey">(c001580)</span></li>
<li>kurifilter-plugins/ikws/CMakeLists.txt <span style="color: \
grey">(51294b5)</span></li>
<li>kurifilter-plugins/ikws/kuriikwsfilter.upd <span style="color: \
grey">(0874ce2)</span></li>
<li>man/man.protocol <span style="color: grey">(cd03f9f)</span></li>
<li>network/kded/CMakeLists.txt <span style="color: grey">(e851f73)</span></li>
<li>network/mimetypes/CMakeLists.txt <span style="color: grey">(c20dc90)</span></li>
<li>nfs/nfs.protocol <span style="color: grey">(4781b3c)</span></li>
<li>sftp/sftp.protocol <span style="color: grey">(6e49ed2)</span></li>
<li>smb/smb.protocol <span style="color: grey">(e15395e)</span></li>
<li>thumbnail/thumbnail.protocol <span style="color: grey">(216f428)</span></li>
<li>trash/CMakeLists.txt <span style="color: grey">(7c72cdc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117859/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic