[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112208: KMix qml applet
From: "Diego Casella" <polentino911 () gmail ! com>
Date: 2014-05-04 21:46:59
Message-ID: 20140504214659.20770.65571 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/
-----------------------------------------------------------
(Updated May 4, 2014, 9:46 p.m.)
Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor \
Poboiko.
Changes
-------
Here you go, an other update with the following changes:
* fixed the resizing issues: now resizing the applet will also update its content to \
fit/shrink to the new applet dimensions;
* added the boolean check to avoid flickering on the slider when updating volume \
level;
* improved icon positioning and padding;
* added a background frame to better distinguish volume controls;
I've also attached two new screenshots to show you how the applet now looks like, \
hope you like it :)
Repository: kmix
Description
-------
KMix qml applet.
As you can see from the screenshot, the applet is pretty much functional: you can \
display all the controls available, change its orientation, and decide to whether \
show all of them or just the Master Control, and refresh its status when new controls \
are added/removed/updated (such as Amarok current playing track). See screenshots \
below :) Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly \
opening the audio applet to change/skip/pause audio track makes little sense to me \
... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon \
kcm page: since visible mixers are already configurable from KMix app, having a \
button to show KMix *and* a button to modify Mixers visibilty made little sense here \
too, so I preferred to give more visibility to Phonon kcm;
Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so \
it is not possible to scroll over to increase/decrease the master \
control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if \
you do so, KMix will show its GUI at every login and you have to close it manually. \
This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix \
window will not restored anymore: this needs to be pathed as well.
* resize doesn't work properly.
Diffs (updated)
-----
plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml 7e87c8e
plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml 26f2968
plasma/kmix-applet-qml/contents/ui/MixersList.qml 66bda73
plasma/kmix-applet-qml/contents/ui/VerticalControl.qml 1702be7
plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml bab9ac6
plasma/kmix-applet-qml/contents/ui/kmixapplet.qml eecb91c
Diff: https://git.reviewboard.kde.org/r/112208/diff/
Testing
-------
Tested against master and works fine.
File Attachments (updated)
----------------
Default look
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
Menu Actions
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
Applet Config Options
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
Vertical Control
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
ToolButton label and Config page after updates
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
Control Icon and Label left aligned
https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
Kmix, horizontal view
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png
Kmix applet, vertical view
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/7efb308a-c306-47c2-883f-64d1f32db5b5__kmix_vertical_new.png
Thanks,
Diego Casella
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112208/">https://git.reviewboard.kde.org/r/112208/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and \
Igor Poboiko.</div> <div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated May 4, 2014, 9:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here you go, an other update with the following changes:
* fixed the resizing issues: now resizing the applet will also update its content to \
fit/shrink to the new applet dimensions;
* added the boolean check to avoid flickering on the slider when updating volume \
level;
* improved icon positioning and padding;
* added a background frame to better distinguish volume controls;
I've also attached two new screenshots to show you how the applet now looks like, \
hope you like it :)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KMix qml applet. As you can see from the screenshot, the applet is \
pretty much functional: you can display all the controls available, change its \
orientation, and decide to whether show all of them or just the Master Control, and \
refresh its status when new controls are added/removed/updated (such as Amarok \
current playing track). See screenshots below :) Differences from the old kmix tray:
* no media player controls ( I never investigated how to get them, but honestly \
opening the audio applet to change/skip/pause audio track makes little sense to me \
... if anyone wants this feature back, don't be shy and step in);
* the button used to select which Mixers are visible has been changed to open Phonon \
kcm page: since visible mixers are already configurable from KMix app, having a \
button to show KMix *and* a button to modify Mixers visibilty made little sense here \
too, so I preferred to give more visibility to Phonon kcm;
Known issues:
* there is still no way to get notified of mouse wheel events over the popupIcon, so \
it is not possible to scroll over to increase/decrease the master \
control volume;
* no scroll events over the sliders too;
* if you want to use the applet you most likely will disable KMix tray icon but, if \
you do so, KMix will show its GUI at every login and you have to close it manually. \
This requires KMix to be patched. Furthermore, if you click "KMix Setup" \
button, KMix window will not restored anymore: this needs to be \
pathed as well.
* resize doesn't work properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against master and works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml <span style="color: \
grey">(7e87c8e)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml <span \
style="color: grey">(26f2968)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/MixersList.qml <span style="color: \
grey">(66bda73)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/VerticalControl.qml <span style="color: \
grey">(1702be7)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml <span \
style="color: grey">(bab9ac6)</span></li>
<li>plasma/kmix-applet-qml/contents/ui/kmixapplet.qml <span style="color: \
grey">(eecb91c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112208/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png">Default \
look</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png">Menu \
Actions</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png">Applet \
Config Options</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png">Vertical \
Control</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png">ToolButton \
label and Config page after updates</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png">Control \
Icon and Label left aligned</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png">Kmix, \
horizontal view</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/7efb308a-c306-47c2-883f-64d1f32db5b5__kmix_vertical_new.png">Kmix \
applet, vertical view</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic