'Re: Review Request 117894: Add a kscreenlocker_test test application'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117894: Add a kscreenlocker_test test application
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-05-01 17:00:36
Message-ID: 20140501170036.20093.55598 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117894/#review57069
-----------------------------------------------------------

The greeter is invokable on it's own anyway, what benefit does this have?

- David Edmundson

On April 30, 2014, 9:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117894/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 9:44 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Wolfgang Bauer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Add a kscreenlocker_test test application
> 
> The idea is to have a small test application for the screenlocker part
> to test without having to restart ksmserver.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/CMakeLists.txt 700cdff95f46125952ab2503bb125c5b6cd3ce67 
>   ksmserver/screenlocker/tests/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/tests/kscreenlocker_main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117894/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117894/">https://git.reviewboard.kde.org/r/117894/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The greeter is invokable \
on it&#39;s own anyway, what benefit does this have?</pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On April 30th, 2014, 9:44 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Wolfgang Bauer.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 9:44 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a kscreenlocker_test test application

The idea is to have a small test application for the screenlocker part
to test without having to restart ksmserver.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(700cdff95f46125952ab2503bb125c5b6cd3ce67)</span></li>

 <li>ksmserver/screenlocker/tests/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/screenlocker/tests/kscreenlocker_main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117894/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 