'Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for oth'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for oth
From:       "Commit Hook" <null () kde ! org>
Date:       2014-05-01 6:06:33
Message-ID: 20140501060633.1393.31113 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915/#review57044
-----------------------------------------------------------

This review has been submitted with commit 121e51d74ff50a3644f275d5cfb571326c7a7286 \
by Shantanu Tushar to branch master.

- Commit Hook

On April 30, 2014, 9:01 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117915/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 9:01 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Just like the Nepomuk media source, the Baloo media source needs to provide the \
> date/time information for media. This is used to sort the media to show the more \
> recent media first. For images, the date/time when the photo was actually taken is \
> used, and the file creation date/time is used for other media. 
> 
> Diffs
> -----
> 
> plugins/baloosearch/CMakeLists.txt 1ff81fb 
> plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION 
> plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION 
> plugins/baloosearch/baloosearchmediasource.h e315de4 
> plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 
> plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION 
> plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION 
> plugins/baloosearch/searchresulthandler.h PRE-CREATION 
> plugins/baloosearch/searchresulthandler.cpp PRE-CREATION 
> plugins/baloosearch/videosearchresulthandler.h PRE-CREATION 
> plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117915/diff/
> 
> 
> Testing
> -------
> 
> Tested with all three types of media, works fine. Unit tests for the new code to \
> follow. 
> 
> Thanks,
> 
> Shantanu Tushar
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117915/">https://git.reviewboard.kde.org/r/117915/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 121e51d74ff50a3644f275d5cfb571326c7a7286 by Shantanu Tushar to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On April 30th, 2014, 9:01 p.m. UTC, Shantanu Tushar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By Shantanu Tushar.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 9:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just like the Nepomuk media source, the Baloo media source needs to \
provide the date/time information for media. This is used to sort the media to show \
the more recent media first. For images, the date/time when the photo was actually \
taken is used, and the file creation date/time is used for other media.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with all three types of media, works fine. Unit tests for the new \
code to follow.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/baloosearch/CMakeLists.txt <span style="color: \
grey">(1ff81fb)</span></li>

 <li>plugins/baloosearch/audiosearchresulthandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/audiosearchresulthandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/baloosearchmediasource.h <span style="color: \
grey">(e315de4)</span></li>

 <li>plugins/baloosearch/baloosearchmediasource.cpp <span style="color: \
grey">(7ebfa61)</span></li>

 <li>plugins/baloosearch/imagesearchresulthandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/imagesearchresulthandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/searchresulthandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/searchresulthandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/videosearchresulthandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/baloosearch/videosearchresulthandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117915/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 