From kde-panel-devel Wed Apr 30 21:01:45 2014 From: "Shantanu Tushar" Date: Wed, 30 Apr 2014 21:01:45 +0000 To: kde-panel-devel Subject: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other f Message-Id: <20140430210145.13676.64526 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139889172531744 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5048005880282002271==" --===============5048005880282002271== Content-Type: multipart/alternative; boundary="===============4656948479781989831==" --===============4656948479781989831== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117915/ ----------------------------------------------------------- Review request for Plasma and Vishesh Handa. Repository: plasma-mediacenter Description ------- Just like the Nepomuk media source, the Baloo media source needs to provide the date/time information for media. This is used to sort the media to show the more recent media first. For images, the date/time when the photo was actually taken is used, and the file creation date/time is used for other media. Diffs ----- plugins/baloosearch/CMakeLists.txt 1ff81fb plugins/baloosearch/audiosearchresulthandler.h PRE-CREATION plugins/baloosearch/audiosearchresulthandler.cpp PRE-CREATION plugins/baloosearch/baloosearchmediasource.h e315de4 plugins/baloosearch/baloosearchmediasource.cpp 7ebfa61 plugins/baloosearch/imagesearchresulthandler.h PRE-CREATION plugins/baloosearch/imagesearchresulthandler.cpp PRE-CREATION plugins/baloosearch/searchresulthandler.h PRE-CREATION plugins/baloosearch/searchresulthandler.cpp PRE-CREATION plugins/baloosearch/videosearchresulthandler.h PRE-CREATION plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117915/diff/ Testing ------- Tested with all three types of media, works fine. Unit tests for the new code to follow. Thanks, Shantanu Tushar --===============4656948479781989831== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117915/

Review request for Plasma and Vishesh Handa.
By Shantanu Tushar.
Repository: plasma-mediacenter

Description 

Just like the Nepomuk media source, the Baloo media source needs to provide the date/time information for media. This is used to sort the media to show the more recent media first.
For images, the date/time when the photo was actually taken is used, and the file creation date/time is used for other media.

Testing 

Tested with all three types of media, works fine. Unit tests for the new code to follow.

Diffs

  • plugins/baloosearch/CMakeLists.txt (1ff81fb)
  • plugins/baloosearch/audiosearchresulthandler.h (PRE-CREATION)
  • plugins/baloosearch/audiosearchresulthandler.cpp (PRE-CREATION)
  • plugins/baloosearch/baloosearchmediasource.h (e315de4)
  • plugins/baloosearch/baloosearchmediasource.cpp (7ebfa61)
  • plugins/baloosearch/imagesearchresulthandler.h (PRE-CREATION)
  • plugins/baloosearch/imagesearchresulthandler.cpp (PRE-CREATION)
  • plugins/baloosearch/searchresulthandler.h (PRE-CREATION)
  • plugins/baloosearch/searchresulthandler.cpp (PRE-CREATION)
  • plugins/baloosearch/videosearchresulthandler.h (PRE-CREATION)
  • plugins/baloosearch/videosearchresulthandler.cpp (PRE-CREATION)

View Diff
--===============4656948479781989831==-- --===============5048005880282002271== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5048005880282002271==--