[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117867: Do not cache media lists to a database
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2014-04-30 17:06:41
Message-ID: 20140430170641.27257.86119 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117867/#review57015
-----------------------------------------------------------
libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39730>
${QT_QTSQL_LIBRARIES} shouldn't be required
libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39729>
${Boost_LIBRARIES} shouldn't be required
libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117867/#comment39728>
${QT_QTSQL_LIBRARIES} and ${Boost_LIBRARIES shouldn't be needed now
libs/mediacenter/medialibrary.h
<https://git.reviewboard.kde.org/r/117867/#comment39731>
shouldn't be required
- Sinny Kumari
On April 29, 2014, 1:13 p.m., Shantanu Tushar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117867/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 1:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> We started caching results from media sources due to our primary data source \
> (Nepomuk) was quite slow and the experience was quite bad both for fetching media \
> and searching through it. Going forward, Baloo is our primary data source, and was \
> found to be quite performant. Given this, the additional complexity of maintaining \
> a cache in DB is too much for the 1-2 second increase in Media Library load times.
> Note that we are still able to pull in data from multiple data sources, we just \
> won't store it on disk.
>
> Diffs
> -----
>
> README be3e060
> cmake/FindQxOrm.cmake 3c1fae1
> libs/CMakeLists.txt 32d45c2
> libs/mediacenter/CMakeLists.txt 809d2c0
> libs/mediacenter/album.h 64b1205
> libs/mediacenter/album.cpp 391a420
> libs/mediacenter/artist.h 064aa02
> libs/mediacenter/artist.cpp 6b32269
> libs/mediacenter/media.h 830ad57
> libs/mediacenter/media.cpp a56a693
> libs/mediacenter/medialibrary.h 8f9b5d3
> libs/mediacenter/medialibrary.cpp 8f49c05
> libs/mediacenter/pmcalbum.h 40c42fe
> libs/mediacenter/pmcartist.h f15a2e2
> libs/mediacenter/pmcmedia.cpp d94d6c7
> libs/mediacenter/precompiled.h 73490b8
> libs/mediacenter/qxorm_export.h 33fbf11
> libs/mediacenter/test/medialibrarytest.h 2f8b476
> libs/mediacenter/test/medialibrarytest.cpp bb20a61
> libs/mediacenter/test/mediatest.h 965bc7e
> libs/mediacenter/test/mediatest.cpp 4f44334
>
> Diff: https://git.reviewboard.kde.org/r/117867/diff/
>
>
> Testing
> -------
>
> Unit tests pass, functionality works as expected.
>
>
> Thanks,
>
> Shantanu Tushar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117867/">https://git.reviewboard.kde.org/r/117867/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117867/diff/1/?file=269159#file269159line81" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">81</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">QT_QTSQL_LIBRARIES</span><span \
class="o">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">46</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span \
class="nv">QT_QTSQL_LIBRARIES</span><span class="o">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">${QT_QTSQL_LIBRARIES} shouldn't be required</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117867/diff/1/?file=269159#file269159line87" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">87</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">Boost_LIBRARIES</span><span \
class="o">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">52</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span \
class="nv">Boost_LIBRARIES</span><span class="o">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">${Boost_LIBRARIES} shouldn't be required</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117867/diff/1/?file=269159#file269159line121" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">121</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">QT_QTSQL_LIBRARIES</span><span class="o">}</span> \
<span class="o">${</span><span class="nv">QT_QTTEST_LIBRARIES</span><span \
class="o">}</span> <span class="o">${</span><span \
class="nv">QT_QTGUI_LIBRARIES</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTNETWORK_LIBRARIES</span><span \
class="o">}</span> <span class="o">${</span><span \
class="nv">QT_QTXML_LIBRARIES</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTDECLARATIVE_LIBRARIES</span><span \
class="o">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">85</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span \
class="nv">QT_QTSQL_LIBRARIES</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTTEST_LIBRARIES</span><span \
class="o">}</span> <span class="o">${</span><span \
class="nv">QT_QTGUI_LIBRARIES</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTNETWORK_LIBRARIES</span><span \
class="o">}</span> <span class="o">${</span><span \
class="nv">QT_QTXML_LIBRARIES</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTDECLARATIVE_LIBRARIES</span><span \
class="o">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">${QT_QTSQL_LIBRARIES} and ${Boost_LIBRARIES shouldn't be needed \
now</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117867/diff/1/?file=269166#file269166line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/medialibrary.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_SIGNALS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">29</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> \
<span class="n">QSqlError</span><span class="p">;</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">class</span> <span class="n">QSqlError</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">shouldn't be required</pre> </div>
<br />
<p>- Sinny Kumari</p>
<br />
<p>On April 29th, 2014, 1:13 p.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 1:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We started caching results from media sources due to our primary data \
source (Nepomuk) was quite slow and the experience was quite bad both for fetching \
media and searching through it. Going forward, Baloo is our primary data source, and \
was found to be quite performant. Given this, the additional complexity of \
maintaining a cache in DB is too much for the 1-2 second increase in Media Library \
load times.
Note that we are still able to pull in data from multiple data sources, we just \
won't store it on disk.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests pass, functionality works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README <span style="color: grey">(be3e060)</span></li>
<li>cmake/FindQxOrm.cmake <span style="color: grey">(3c1fae1)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(32d45c2)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(809d2c0)</span></li>
<li>libs/mediacenter/album.h <span style="color: grey">(64b1205)</span></li>
<li>libs/mediacenter/album.cpp <span style="color: grey">(391a420)</span></li>
<li>libs/mediacenter/artist.h <span style="color: grey">(064aa02)</span></li>
<li>libs/mediacenter/artist.cpp <span style="color: grey">(6b32269)</span></li>
<li>libs/mediacenter/media.h <span style="color: grey">(830ad57)</span></li>
<li>libs/mediacenter/media.cpp <span style="color: grey">(a56a693)</span></li>
<li>libs/mediacenter/medialibrary.h <span style="color: grey">(8f9b5d3)</span></li>
<li>libs/mediacenter/medialibrary.cpp <span style="color: \
grey">(8f49c05)</span></li>
<li>libs/mediacenter/pmcalbum.h <span style="color: grey">(40c42fe)</span></li>
<li>libs/mediacenter/pmcartist.h <span style="color: grey">(f15a2e2)</span></li>
<li>libs/mediacenter/pmcmedia.cpp <span style="color: grey">(d94d6c7)</span></li>
<li>libs/mediacenter/precompiled.h <span style="color: grey">(73490b8)</span></li>
<li>libs/mediacenter/qxorm_export.h <span style="color: grey">(33fbf11)</span></li>
<li>libs/mediacenter/test/medialibrarytest.h <span style="color: \
grey">(2f8b476)</span></li>
<li>libs/mediacenter/test/medialibrarytest.cpp <span style="color: \
grey">(bb20a61)</span></li>
<li>libs/mediacenter/test/mediatest.h <span style="color: \
grey">(965bc7e)</span></li>
<li>libs/mediacenter/test/mediatest.cpp <span style="color: \
grey">(4f44334)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117867/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic