[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dia
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-04-30 12:06:38
Message-ID: 20140430120638.1393.35857 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117897/#review56976
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On April 30, 2014, 11:59 a.m., Eike Hein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117897/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:59 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Dialog::hideOnWindowDeactivate is evaluated in Dialog::focusOutEvent, i.e. if it's \
> true and the dialog loses focus, the dialog will hide.
> This means dialogs that open sub windows (sub dialogs, or QMenusfor that matter) \
> need to carefully manage hideOnWindowDeactivate to be false for the duration of the \
> sub window being open.
> This can mean a lot of scaffolding, and duplication thereof across various applets. \
> For example, Kickoff manages hideOnWindowDeactivate for its context menus. So does \
> Kicker, and Kicker also has to concern itself with sub dialogs, where it needs to \
> interact in complicated ways with open/close management for subdialogs.
> This patch introduces the assumption that if the focus loss is due to a child \
> window of the dialog gaining focus, the dialog shouldn't actually be hidden, \
> simplifying applet code.
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp 58de55b
>
> Diff: https://git.reviewboard.kde.org/r/117897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eike Hein
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117897/">https://git.reviewboard.kde.org/r/117897/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Marco Martin</p>
<br />
<p>On April 30th, 2014, 11:59 a.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 11:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dialog::hideOnWindowDeactivate is evaluated in Dialog::focusOutEvent, \
i.e. if it's true and the dialog loses focus, the dialog will hide.
This means dialogs that open sub windows (sub dialogs, or QMenusfor that matter) need \
to carefully manage hideOnWindowDeactivate to be false for the duration of the sub \
window being open.
This can mean a lot of scaffolding, and duplication thereof across various applets. \
For example, Kickoff manages hideOnWindowDeactivate for its context menus. So does \
Kicker, and Kicker also has to concern itself with sub dialogs, where it needs to \
interact in complicated ways with open/close management for subdialogs.
This patch introduces the assumption that if the focus loss is due to a child window \
of the dialog gaining focus, the dialog shouldn't actually be hidden, simplifying \
applet code.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(58de55b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117897/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic