From kde-panel-devel Wed Apr 30 11:18:47 2014 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Wed, 30 Apr 2014 11:18:47 +0000 To: kde-panel-devel Subject: Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph Message-Id: <20140430111847.1393.57864 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=139885674819706 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2749084947673589766==" --===============2749084947673589766== Content-Type: multipart/alternative; boundary="===============4702456943174597437==" --===============4702456943174597437== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/ ----------------------------------------------------------- (Updated April 30, 2014, 11:18 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Alexander Richardson. Bugs: 333482 http://bugs.kde.org/show_bug.cgi?id=333482 Repository: plasma-framework Description ------- Discard window thumbnail pixmap after texture got destroyed by SceneGraph If the window holding the WindowThumbnail item goes away the texture hold by the node is destroyed but our bound window pixmap is not yet freed. This results in incorrect state the next time the WindowThumbnail is shown. To get back into a clean state discardPixmap() is called if there is no texture but a bound low level pixmap. BUG: 333482 Diffs ----- src/declarativeimports/core/windowthumbnail.cpp d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 Diff: https://git.reviewboard.kde.org/r/117824/diff/ Testing ------- Thanks, Martin Gräßlin --===============4702456943174597437== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/

This change has been marked as submitted.

Review request for Plasma and Alexander Richardson.

By Martin Gräßlin.

Updated April 30, 2014, 11:18 a.m.

Bugs: 333482

Repository: plasma-framework

Description

Discard window thumbnail pixmap after texture got destroyed by SceneGraph

If the window holding the WindowThumbnail item goes away the texture hold
by the node is destroyed but our bound window pixmap is not yet freed.
This results in incorrect state the next time the WindowThumbnail is
shown.

To get back into a clean state discardPixmap() is called if there is no
texture but a bound low level pixmap.

BUG: 333482

Diffs

src/declarativeimports/core/windowthumbnail.cpp (d1a7fef1fc5fd119592710d80274d2abe0c8b3b1)

View Diff

--===============4702456943174597437==-- --===============2749084947673589766== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2749084947673589766==--