'Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-04-30 10:30:45
Message-ID: 20140430103045.27257.27508 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117824/#review56962
-----------------------------------------------------------

Ship it!

- David Edmundson

On April 30, 2014, 5:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117824/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 5:44 a.m.)
> 
> 
> Review request for Plasma and Alexander Richardson.
> 
> 
> Bugs: 333482
>     http://bugs.kde.org/show_bug.cgi?id=333482
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Discard window thumbnail pixmap after texture got destroyed by SceneGraph
> 
> If the window holding the WindowThumbnail item goes away the texture hold
> by the node is destroyed but our bound window pixmap is not yet freed.
> This results in incorrect state the next time the WindowThumbnail is
> shown.
> 
> To get back into a clean state discardPixmap() is called if there is no
> texture but a bound low level pixmap.
> 
> BUG: 333482
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 
> 
> Diff: https://git.reviewboard.kde.org/r/117824/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117824/">https://git.reviewboard.kde.org/r/117824/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- David Edmundson</p>

<br />
<p>On April 30th, 2014, 5:44 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Alexander Richardson.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 5:44 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=333482">333482</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Discard window thumbnail pixmap after texture got destroyed by \
SceneGraph

If the window holding the WindowThumbnail item goes away the texture hold
by the node is destroyed but our bound window pixmap is not yet freed.
This results in incorrect state the next time the WindowThumbnail is
shown.

To get back into a clean state discardPixmap() is called if there is no
texture but a bound low level pixmap.

BUG: 333482</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: \
grey">(d1a7fef1fc5fd119592710d80274d2abe0c8b3b1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117824/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 