[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117775: rename oxygen sound files for co-installability
From: "Jonathan Riddell" <jr () jriddell ! org>
Date: 2014-04-30 9:08:44
Message-ID: 20140430090844.1393.39239 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117775/
-----------------------------------------------------------
(Updated April 30, 2014, 9:08 a.m.)
Review request for Plasma.
Repository: oxygen
Description
-------
Oxygen sound files were part of kde-runtime so need to be co-installable with \
kdelibs4 world. Use Oxygen name to give them a different name and correct identify \
the sound theme. There are various .notifyrc files that use these files which I'll \
submit patches for should this one be accepted.
Diffs
-----
sounds/KDE-Im-Cant-Connect.ogg
sounds/KDE-Im-Connection-Lost.ogg
sounds/KDE-Im-Contact-In.ogg
sounds/KDE-Im-Contact-Out.ogg
sounds/KDE-Im-Error-On-Connection.ogg
sounds/KDE-Im-Highlight-Msg.ogg
sounds/KDE-Im-Internal-Error.ogg
sounds/KDE-Im-Irc-Event.ogg
sounds/KDE-Im-Low-Priority-Message.ogg
sounds/KDE-Im-Message-In.ogg
sounds/KDE-Im-Message-Out.ogg
sounds/KDE-Im-Network-Problems.ogg
sounds/KDE-Im-New-Mail.ogg
sounds/KDE-Im-Nudge.ogg
sounds/KDE-Im-Phone-Ring.ogg
sounds/KDE-Im-Sms.ogg
sounds/KDE-Im-User-Auth.ogg
sounds/KDE-K3B-Finish-Error.ogg
sounds/KDE-K3B-Finish-Success.ogg
sounds/KDE-K3B-Insert-Medium.ogg
sounds/KDE-Sys-App-Error-Critical.ogg
sounds/KDE-Sys-App-Error-Serious-Very.ogg
sounds/KDE-Sys-App-Error-Serious.ogg
sounds/KDE-Sys-App-Error.ogg
sounds/KDE-Sys-App-Message.ogg
sounds/KDE-Sys-App-Negative.ogg
sounds/KDE-Sys-App-Positive.ogg
sounds/KDE-Sys-Error-Printing.ogg
sounds/KDE-Sys-File-Open-Foes.ogg
sounds/KDE-Sys-List-End.ogg
sounds/KDE-Sys-List-Match-Multiple.ogg
sounds/KDE-Sys-List-Match-No.ogg
sounds/KDE-Sys-Log-In-Long.ogg
sounds/KDE-Sys-Log-In-Short.ogg
sounds/KDE-Sys-Log-In.ogg
sounds/KDE-Sys-Log-Out.ogg
sounds/KDE-Sys-Question.ogg
sounds/KDE-Sys-Special.ogg
sounds/KDE-Sys-Trash-Emptied.ogg
sounds/KDE-Sys-Warning.ogg
sounds/KDE-Window-All-Desktops-Not.ogg
sounds/KDE-Window-All-Desktops.ogg
sounds/KDE-Window-Close.ogg
sounds/KDE-Window-Maximize.ogg
sounds/KDE-Window-Minimize.ogg
sounds/KDE-Window-Move-Stop.ogg
sounds/KDE-Window-Move.ogg
sounds/KDE-Window-Shade-Down.ogg
sounds/KDE-Window-Shade-Up.ogg
Diff: https://git.reviewboard.kde.org/r/117775/diff/
Testing
-------
Thanks,
Jonathan Riddell
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117775/">https://git.reviewboard.kde.org/r/117775/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 9:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Oxygen sound files were part of kde-runtime so need to be co-installable \
with kdelibs4 world. Use Oxygen name to give them a different name and correct \
identify the sound theme. There are various .notifyrc files that use these files \
which I'll submit patches for should this one be accepted. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sounds/KDE-Im-Cant-Connect.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Connection-Lost.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Contact-In.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Contact-Out.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Error-On-Connection.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Highlight-Msg.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Internal-Error.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Irc-Event.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Low-Priority-Message.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Message-In.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Message-Out.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Network-Problems.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-New-Mail.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Nudge.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Phone-Ring.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-Sms.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Im-User-Auth.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-K3B-Finish-Error.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-K3B-Finish-Success.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-K3B-Insert-Medium.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Error-Critical.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Error-Serious-Very.ogg <span style="color: \
grey">()</span></li>
<li>sounds/KDE-Sys-App-Error-Serious.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Error.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Message.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Negative.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-App-Positive.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Error-Printing.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-File-Open-Foes.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-List-End.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-List-Match-Multiple.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-List-Match-No.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Log-In-Long.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Log-In-Short.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Log-In.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Log-Out.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Question.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Special.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Trash-Emptied.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Sys-Warning.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-All-Desktops-Not.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-All-Desktops.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Close.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Maximize.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Minimize.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Move-Stop.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Move.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Shade-Down.ogg <span style="color: grey">()</span></li>
<li>sounds/KDE-Window-Shade-Up.ogg <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117775/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic