'Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fr'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fr
From:       "Jonathan Riddell" <jr () jriddell ! org>
Date:       2014-04-29 15:10:02
Message-ID: 20140429151002.27257.78371 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117874/
-----------------------------------------------------------

(Updated April 29, 2014, 3:10 p.m.)

Review request for Plasma.

Changes
-------

Update to delete the force_krunner_lock_shortcut_unreg binary too

Repository: plasma-workspace

Description
-------

don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install

Diffs (updated)
-----

  drkonqi/CMakeLists.txt 4794621 
  drkonqi/drkonqi-rename-config-section.upd 413908f 
  kglobalaccel/CMakeLists.txt 1ddee63 
  kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434a 
  klipper/CMakeLists.txt f4bd831 
  klipper/klipper-kconfigxt.upd 586948e 
  ksmserver/CMakeLists.txt 65af7d8 
  ksmserver/ksmserver_shortcuts.upd 760f6a9 
  ksmserver/screenlocker/CMakeLists.txt 700cdff 
  ksmserver/screenlocker/data/CMakeLists.txt 624eaf3 
  ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp fe1cd8a 
  ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d52 

Diff: https://git.reviewboard.kde.org/r/117874/diff/

Testing
-------

Thanks,

Jonathan Riddell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117874/">https://git.reviewboard.kde.org/r/117874/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>

<p style="color: grey;"><i>Updated April 29, 2014, 3:10 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update to delete the force_krunner_lock_shortcut_unreg binary too</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">don&#39;t install kconf_update files from KDE4 land, KF5 apps start with \
a fresh install</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>drkonqi/CMakeLists.txt <span style="color: grey">(4794621)</span></li>

 <li>drkonqi/drkonqi-rename-config-section.upd <span style="color: \
grey">(413908f)</span></li>

 <li>kglobalaccel/CMakeLists.txt <span style="color: grey">(1ddee63)</span></li>

 <li>kglobalaccel/kconf/kdedglobalaccel_kde42.upd <span style="color: \
grey">(260434a)</span></li>

 <li>klipper/CMakeLists.txt <span style="color: grey">(f4bd831)</span></li>

 <li>klipper/klipper-kconfigxt.upd <span style="color: grey">(586948e)</span></li>

 <li>ksmserver/CMakeLists.txt <span style="color: grey">(65af7d8)</span></li>

 <li>ksmserver/ksmserver_shortcuts.upd <span style="color: \
grey">(760f6a9)</span></li>

 <li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(700cdff)</span></li>

 <li>ksmserver/screenlocker/data/CMakeLists.txt <span style="color: \
grey">(624eaf3)</span></li>

 <li>ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp <span \
style="color: grey">(fe1cd8a)</span></li>

 <li>ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd <span \
style="color: grey">(cbc4d52)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117874/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 