[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117784: Remove duplicated ConfigLoader
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-04-27 20:50:31
Message-ID: 20140427205031.9429.88878 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 26, 2014, 1:49 p.m., Marco Martin wrote:
> > did you try a service? here for instance the mpris dataengine doesn't work \
> > anymore, i can't send commands like pause/play
>
> Martin Klapetek wrote:
> Speaking with the mpris applet maintainer hat - as it was committed, this^ is not a \
> problem anymore I take?
it works correctly now, the problem was fixed prior pushing
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117784/#review56623
-----------------------------------------------------------
On April 26, 2014, 3:09 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117784/
> -----------------------------------------------------------
>
> (Updated April 26, 2014, 3:09 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Remove duplicated ConfigLoaderin Plasma.
>
> This moved to KConfigGui as KConfigLoader.
>
> Use of private KConfig API in Service had to be ported to use only
> public method.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 8501228
> autotests/configloadertest.h 791b0f6
> autotests/configloadertest.cpp a89d951
> autotests/configloadertest.xml 13ccd32
> src/plasma/CMakeLists.txt a7e9892
> src/plasma/applet.h 06147fb
> src/plasma/applet.cpp 88c4973
> src/plasma/configloader.h 4ef9cb4
> src/plasma/configloader.cpp 4822548
> src/plasma/containment.cpp 95c9da0
> src/plasma/dataengine.cpp 86e33d1
> src/plasma/private/applet_p.h f31f02e
> src/plasma/private/applet_p.cpp d0ac89e
> src/plasma/private/configloader_p.h 25bb6b8
> src/plasma/private/configloaderhandler_p.h df96a33
> src/plasma/private/service_p.h 3a70392
> src/plasma/service.cpp 1b3cbaf
> src/scriptengines/qml/plasmoid/appletinterface.cpp f36270c
> src/scriptengines/qml/plasmoid/wallpaperinterface.h bd70aa3
> src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a3a9b51
>
> Diff: https://git.reviewboard.kde.org/r/117784/diff/
>
>
> Testing
> -------
>
> Ran plasma shell as before.
> plasmaengineexplorer service seems to lists entries correctly.
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117784/">https://git.reviewboard.kde.org/r/117784/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 26th, 2014, 1:49 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">did you try a service? here for instance the mpris dataengine \
doesn't work anymore, i can't send commands like pause/play</pre> \
</blockquote>
<p>On April 27th, 2014, 8:42 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Speaking with the mpris \
applet maintainer hat - as it was committed, this^ is not a problem anymore I \
take?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it works correctly now, \
the problem was fixed prior pushing</pre> <br />
<p>- Marco</p>
<br />
<p>On April 26th, 2014, 3:09 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 26, 2014, 3:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove duplicated ConfigLoaderin Plasma.
This moved to KConfigGui as KConfigLoader.
Use of private KConfig API in Service had to be ported to use only
public method.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran plasma shell as before. plasmaengineexplorer service seems to lists \
entries correctly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(8501228)</span></li>
<li>autotests/configloadertest.h <span style="color: grey">(791b0f6)</span></li>
<li>autotests/configloadertest.cpp <span style="color: grey">(a89d951)</span></li>
<li>autotests/configloadertest.xml <span style="color: grey">(13ccd32)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(a7e9892)</span></li>
<li>src/plasma/applet.h <span style="color: grey">(06147fb)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(88c4973)</span></li>
<li>src/plasma/configloader.h <span style="color: grey">(4ef9cb4)</span></li>
<li>src/plasma/configloader.cpp <span style="color: grey">(4822548)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(95c9da0)</span></li>
<li>src/plasma/dataengine.cpp <span style="color: grey">(86e33d1)</span></li>
<li>src/plasma/private/applet_p.h <span style="color: grey">(f31f02e)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(d0ac89e)</span></li>
<li>src/plasma/private/configloader_p.h <span style="color: \
grey">(25bb6b8)</span></li>
<li>src/plasma/private/configloaderhandler_p.h <span style="color: \
grey">(df96a33)</span></li>
<li>src/plasma/private/service_p.h <span style="color: grey">(3a70392)</span></li>
<li>src/plasma/service.cpp <span style="color: grey">(1b3cbaf)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(f36270c)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.h <span style="color: \
grey">(bd70aa3)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: \
grey">(a3a9b51)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117784/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic