'Re: Review Request 117801: Make PMC MPRIS compatible'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117801: Make PMC MPRIS compatible
From:       "Ashish Madeti" <ashishmadeti () gmail ! com>
Date:       2014-04-27 19:12:49
Message-ID: 20140427191249.9428.70397 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801/
-----------------------------------------------------------

(Updated April 28, 2014, 12:42 a.m.)

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.

Changes
-------

Change the include lines to point to the new location of mpris2/

Repository: plasma-mediacenter

Description
-------

Add Dbus adaptors through which any other application can programmatically control \
PMC using MPRIS specifications. \
http://specifications.freedesktop.org/mpris-spec/latest/index.html

Diffs (updated)
-----

  libs/mediacenter/CMakeLists.txt 37769f6 
  libs/mediacenter/mpris2/mediaplayer2.h PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2.cpp PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2player.h PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2player.cpp PRE-CREATION 
  libs/mediacenter/mpris2/mpris2.h PRE-CREATION 
  libs/mediacenter/mpris2/mpris2.cpp PRE-CREATION 
  mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
  shells/newshell/mainwindow.h 9cbf77c 
  shells/newshell/mainwindow.cpp c1be61a 
  shells/newshell/package/contents/ui/mediacenter.qml 50f3576 

Diff: https://git.reviewboard.kde.org/r/117801/diff/

Testing
-------

Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester

Thanks,

Ashish Madeti

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117801/">https://git.reviewboard.kde.org/r/117801/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Ashish Madeti.</div>

<p style="color: grey;"><i>Updated April 28, 2014, 12:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change the include lines to point to the new location of mpris2/</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add Dbus adaptors through which any other application can \
programmatically control PMC using MPRIS specifications. \
http://specifications.freedesktop.org/mpris-spec/latest/index.html</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with qdbusviewer and mpristester : \
https://github.com/randomguy3/mpristester</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(37769f6)</span></li>

 <li>libs/mediacenter/mpris2/mediaplayer2.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/mediacenter/mpris2/mediaplayer2.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/mediacenter/mpris2/mediaplayer2player.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/mediacenter/mpris2/mediaplayer2player.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/mediacenter/mpris2/mpris2.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/mediacenter/mpris2/mpris2.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(39ed617)</span></li>

 <li>shells/newshell/mainwindow.h <span style="color: grey">(9cbf77c)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(c1be61a)</span></li>

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(50f3576)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117801/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 