'Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForR'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForR
From:       "Ashish Madeti" <ashishmadeti () gmail ! com>
Date:       2014-04-13 16:59:45
Message-ID: 20140413165945.31494.25670 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117510/
-----------------------------------------------------------

(Updated April 13, 2014, 4:59 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

Repository: plasma-mediacenter

Description
-------

Remove the function extractAndSaveDurationInfo() and add a case for \
MediaCenter::DurationRole in setValueForRole().

Diffs
-----

  libs/mediacenter/media.cpp 3ba5d9e 
  libs/mediacenter/medialibrary.h 3ac18a6 
  libs/mediacenter/medialibrary.cpp 713827a 

Diff: https://git.reviewboard.kde.org/r/117510/diff/

Testing
-------

Thanks,

Ashish Madeti

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117510/">https://git.reviewboard.kde.org/r/117510/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Ashish Madeti.</div>

<p style="color: grey;"><i>Updated April 13, 2014, 4:59 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove the function extractAndSaveDurationInfo() and add a case for \
MediaCenter::DurationRole in setValueForRole().</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/media.cpp <span style="color: grey">(3ba5d9e)</span></li>

 <li>libs/mediacenter/medialibrary.h <span style="color: grey">(3ac18a6)</span></li>

 <li>libs/mediacenter/medialibrary.cpp <span style="color: \
grey">(713827a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117510/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 