[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 117276: Add password checking to screenlocker
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-04-01 7:32:10
Message-ID: 20140401073210.13409.30585 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117276/
-----------------------------------------------------------
Review request for Plasma and David Edmundson.
Repository: kde-workspace
Description
-------
Add password checking to screenlocker
A new Authenticator item is introduced and exported to QML. It provides
a slot tryAuthenticate taking the password as a string. If invoked it
creates a KCheckPass object which handles the communication with the
kcheckpass binary to verify the password. If the authentication succeeded
the Authenticator emits a succeeded() signal, on failure a failed()
signal.
The authentication process is bound to a grace timer. While this timer is
active it's not possible to authenticate again. This state is exposed
with a Q_PROPERTY and used by the UI to disable the password field and
unlock button.
Diffs
-----
plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt \
PRE-CREATION plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp \
PRE-CREATION plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c \
PRE-CREATION plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp \
496c0128e6a240a0821848c054ed60e2c2730f04 \
plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
7aa59f81f7257db9ed8306bf732b008036c64d95 \
plasma-workspace/ksmserver/config-ksmserver.h.cmake \
4b60c8c6713089db8c637827c44bb04c37a87abe \
plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt \
53fe38b7452a179f5919e93585573038ea926d00 \
plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h PRE-CREATION \
plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117276/diff/
Testing
-------
Thanks,
Martin Gräßlin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117276/">https://git.reviewboard.kde.org/r/117276/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add password checking to screenlocker
A new Authenticator item is introduced and exported to QML. It provides
a slot tryAuthenticate taking the password as a string. If invoked it
creates a KCheckPass object which handles the communication with the
kcheckpass binary to verify the password. If the authentication succeeded
the Authenticator emits a succeeded() signal, on failure a failed()
signal.
The authentication process is bound to a grace timer. While this timer is
active it's not possible to authenticate again. This state is exposed
with a Q_PROPERTY and used by the UI to disable the password field and
unlock button.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp <span \
style="color: grey">(496c0128e6a240a0821848c054ed60e2c2730f04)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(7aa59f81f7257db9ed8306bf732b008036c64d95)</span></li>
<li>plasma-workspace/ksmserver/config-ksmserver.h.cmake <span style="color: \
grey">(4b60c8c6713089db8c637827c44bb04c37a87abe)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt <span \
style="color: grey">(53fe38b7452a179f5919e93585573038ea926d00)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic