[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 117121: Add property to determine if popups should be inside or outside the paren
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-03-31 9:59:55
Message-ID: 20140331095955.20889.7780 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 27, 2014, 5:57 p.m., Marco Martin wrote:
> > "break" as in.. ?
>
> David Edmundson wrote:
> Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken.
>
> Marco Martin wrote:
> uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png
>
> Marco Martin wrote:
> ah, no, apparently depends from where the applet is
>
> Marco Martin wrote:
> well, i don't see where locateinsideparent should be true.
>
> right now locateinsideparent = true if the window is a desktop.. and that doesn't \
> seem to make any sense?
> if i remove completely locateinsideparent everything seems to just work?
>
> David Edmundson wrote:
> Without ever setting it to true WidgetExplorer won't work when loaded on a second \
> screen which is to the right of the main screen.
> We would try to position it to the left outside the parentItem (which is the entire \
> screen) so it appears on the wrong screen. The fact that it works in any other \
> case is just a fortunate set of circumstances as the logic to make sure it fits in \
> the screen ends up putting it back.
> I will need to add the locateInsideParent: true to the relevant part of in \
> kde-workspace.
> Marco Martin wrote:
> hmm, to me the proper solution would be trying to always put the dialog in the same \
> screen as the parent view
> David Edmundson wrote:
> > the proper solution would be trying to always put the dialog in the same screen \
> > as the parent view
>
> Which is why we need the locateInsideParent. Without it we explicitly calculate \
> that the best position for the widget explorer dialog is off the screen. \
> Calculating something should be completely off the screen and then trying to \
> manipulate it back onto the right screen isn't a very proper solution. We need to \
> fix the initial calculation to be in the right place to start with.
> Relative to the parent the ideal position for widget explorer and any other popup \
> are completely different. One is on top of the parent, the other is outside it. We \
> need a way to tell dialog that as determining it automatically (what we had before \
> this patch) doesn't work safely enough.
>
>
>
Bump.
If you're still not convinced ping me on IRC sometime so I can persuade you that I'm \
totally right. :)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117121/#review54355
-----------------------------------------------------------
On March 27, 2014, 5:34 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117121/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:34 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add property to determine if popups should be inside or outside the parentItem
>
> For some cases of dialog we want to position within the parent item for
> example widget explorer. For popup applets on the desktop the dialog
> should appear outside of the parentItem.
>
> Currently we try to determine it automatically from the window type of
> the parentItem. This worked fine for widget explorer and panels, but
> breaks for popup applets on the desktop.
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.h 3804d18
> src/plasmaquick/dialog.cpp 77c0c8c
>
> Diff: https://git.reviewboard.kde.org/r/117121/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117121/">https://git.reviewboard.kde.org/r/117121/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2014, 5:57 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"break" as in.. ?</pre> </blockquote>
<p>On March 27th, 2014, 7:43 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add kickoff to the \
desktop. Resize it so it's compact then hover over it. Broken.</pre> \
</blockquote>
<p>On March 27th, 2014, 7:51 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm, works for me? \
http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png</pre> </blockquote>
<p>On March 27th, 2014, 7:56 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, no, apparently \
depends from where the applet is</pre> </blockquote>
<p>On March 27th, 2014, 8 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well, i don't see \
where locateinsideparent should be true.
right now locateinsideparent = true if the window is a desktop.. and that doesn't \
seem to make any sense?
if i remove completely locateinsideparent everything seems to just work?</pre>
</blockquote>
<p>On March 27th, 2014, 9:13 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Without ever setting it \
to true WidgetExplorer won't work when loaded on a second screen which is to the \
right of the main screen.
We would try to position it to the left outside the parentItem (which is the entire \
screen) so it appears on the wrong screen. The fact that it works in any other case \
is just a fortunate set of circumstances as the logic to make sure it fits in the \
screen ends up putting it back.
I will need to add the locateInsideParent: true to the relevant part of in \
kde-workspace.</pre> </blockquote>
<p>On March 27th, 2014, 9:26 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm, to me the proper \
solution would be trying to always put the dialog in the same screen as the parent \
view</pre> </blockquote>
<p>On March 27th, 2014, 9:45 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>the proper solution \
would be trying to always put the dialog in the same screen as the parent view
Which is why we need the locateInsideParent. Without it we explicitly calculate that \
the best position for the widget explorer dialog is off the screen. Calculating \
something should be completely off the screen and then trying to manipulate it back \
onto the right screen isn't a very proper solution. We need to fix the initial \
calculation to be in the right place to start with.
Relative to the parent the ideal position for widget explorer and any other popup are \
completely different. One is on top of the parent, the other is outside it. We need a \
way to tell dialog that as determining it automatically (what we had before this \
patch) doesn't work safely enough.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bump. If you're \
still not convinced ping me on IRC sometime so I can persuade you that I'm \
totally right. :)</pre> <br />
<p>- David</p>
<br />
<p>On March 27th, 2014, 5:34 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 27, 2014, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add property to determine if popups should be inside or outside the \
parentItem
For some cases of dialog we want to position within the parent item for
example widget explorer. For popup applets on the desktop the dialog
should appear outside of the parentItem.
Currently we try to determine it automatically from the window type of
the parentItem. This worked fine for widget explorer and panels, but
breaks for popup applets on the desktop.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/dialog.h <span style="color: grey">(3804d18)</span></li>
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(77c0c8c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117121/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic