--===============3155117999618177054== Content-Type: multipart/alternative; boundary="===============0260051623503809852==" --===============0260051623503809852== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review54471 ----------------------------------------------------------- You changed automatically translated entries, that's not necessary. You also forgot a bunch of instances, especially all the Comment= entries. browsingbackends/localfiles/localmusic/localmusic.desktop Never edit translated names in .desktop files, they're automatically translated. Only the Name= field is considered, but not for example Name[nl]= Different languages have different capitalization patterns, and the HIG is just the default for English. You don't have to remove it, as it'll be overwritten anyway, just could save a lot of work next time. browsingbackends/localfiles/localpictures/localpictures.desktop missing browsingbackends/localfiles/localvideos/localvideos.desktop Browse Pictures Browse videos Spot the inconsistency? browsingbackends/localfiles/localvideos/localvideos.desktop Needs capitalization browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop Needs capitalization browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop needs capitalization browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop All Videos browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop needs capitalization browsingbackends/onlineservices/youtube/youtubebackend.desktop Videos needs a capital browsingbackends/utility/fullscreen/pmcfullscreen.desktop Needs capitalization as well - Sebastian Kügler On March 28, 2014, 5:12 p.m., Nikolaos Chatzidakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117139/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 5:12 p.m.) > > > Review request for Plasma and Shantanu Tushar. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. > > > Diffs > ----- > > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 > browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 > browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 > browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 > browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 > browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c > browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 > browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 > > Diff: https://git.reviewboard.kde.org/r/117139/diff/ > > > Testing > ------- > > > Thanks, > > Nikolaos Chatzidakis > > --===============0260051623503809852== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/

You changed automatically translated entries, that's not necessary.

You also forgot a bunch of instances, especially all the Comment= entries.

browsingbackends/localfiles/localmusic/localmusic.desktop (Diff revision 1)
5
Name[bs]=Pregled muzike
5
Name[bs]=Pregled Muzike
Never edit translated names in .desktop files, they're automatically translated. Only the Name= field is considered, but not for example Name[nl]=

Different languages have different capitalization patterns, and the HIG is just the default for English.

You don't have to remove it, as it'll be overwritten anyway, just could save a lot of work next time.

browsingbackends/localfiles/localpictures/localpictures.desktop (Diff revision 1)
33
Comment=Browse folders on your device for pictures
33
Comment=Browse folders on your device for pictures
missing

browsingbackends/localfiles/localvideos/localvideos.desktop (Diff revision 1)
4
Name=Browse videos
4
Name=Browse videos
Browse Pictures
Browse videos 

Spot the inconsistency?

browsingbackends/localfiles/localvideos/localvideos.desktop (Diff revision 1)
33
Comment=Browse folders on your device for videos
33
Comment=Browse folders on your device for videos
Needs capitalization

browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop (Diff revision 1)
34
Comment=Listen to the music on your device
34
Comment=Listen to the music on your device
Needs capitalization

browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop (Diff revision 1)
32
Comment=See the pictures on your device
32
Comment=See the pictures on your device
needs capitalization

browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop (Diff revision 1)
4
Name=All videos
4
Name=All videos
All Videos

browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop (Diff revision 1)
32
Comment=Watch the videos on your device
32
Comment=Watch the videos on your device
needs capitalization

browsingbackends/onlineservices/youtube/youtubebackend.desktop (Diff revision 1)
30
Comment=Watch videos from Youtube
30
Comment=Watch videos from Youtube
Videos needs a capital

browsingbackends/utility/fullscreen/pmcfullscreen.desktop (Diff revision 1)
33
Comment=Toggle fullscreen mode
33
Comment=Toggle fullscreen mode
Needs capitalization as well

- Sebastian Kügler


On March 28th, 2014, 5:12 p.m. UTC, Nikolaos Chatzidakis wrote:

Review request for Plasma and Shantanu Tushar.
By Nikolaos Chatzidakis.

Updated March 28, 2014, 5:12 p.m.

Repository: plasma-mediacenter

Description

This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter.

Diffs

  • browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop (93b7c62)
  • browsingbackends/localfiles/localvideos/localvideos.desktop (4f22968)
  • browsingbackends/localfiles/localpictures/localpictures.desktop (4ffe275)
  • browsingbackends/localfiles/localmusic/localmusic.desktop (ab47666)
  • browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop (9d04068)
  • browsingbackends/onlineservices/youtube/youtubebackend.desktop (4b3ba9c)
  • browsingbackends/utility/fullscreen/pmcfullscreen.desktop (c992932)
  • browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop (a06a168)

View Diff

--===============0260051623503809852==-- --===============3155117999618177054== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3155117999618177054==--